[jboss-jira] [JBoss JIRA] (AS7-3772) Regularize expression handling in the interface resources

Brian Stansberry (JIRA) jira-events at lists.jboss.org
Wed Feb 15 11:41:37 EST 2012


    [ https://issues.jboss.org/browse/AS7-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666842#comment-12666842 ] 

Brian Stansberry commented on AS7-3772:
---------------------------------------

Re: 3) above, instead of passing the OperationContext into ParsedInterfaceCriteria, it probably makes more sense for the OSH to itself resolve the ModelNode param passed into PIC.parse(...) and have PIC solely deal with resolved data.
                
> Regularize expression handling in the interface resources
> ---------------------------------------------------------
>
>                 Key: AS7-3772
>                 URL: https://issues.jboss.org/browse/AS7-3772
>             Project: Application Server 7
>          Issue Type: Task
>          Components: Domain Management
>    Affects Versions: 7.1.0.Final
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>             Fix For: 7.2.0.Alpha1
>
>
> The interface resource code predates the evolution of the AttributeDefinition classes. Convert it over to that and make sure the xml parsers, operation step handlers and ParsedInterfaceCriteria follow the standard practices. Basically,
> 1) Use AD.parseAndSet() in the parsers. This will ensure parsing any criteria type that supports expressions will result in values of type EXPRESSION if appropriate.
> 2) Use AD.validateAndSet() in the MODEL stage of the OSH. This will ensure reading in input values from the CLI/console etc for any criteria type that supports expressions will result in values of type EXPRESSION if appropriate.
> 3) Pass the OperationContext into ParsedInterfaceCriteria and use AD.resolveModelAttribute() for resolution.
> This may not be entirely possible, as interface criteria as a bit unusual types of attributes. But the general intent here should be followed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jboss-jira mailing list