[jboss-jira] [JBoss JIRA] (WFLY-2215) WorkManagerService does not start work manager

[Bartosz Baranowski (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925274#comment-12925274 ] 

Bartosz Baranowski commented on WFLY-2215:
------------------------------------------

How requirement to restart a workmanager AFTER it has been stopped is wrong?. 
If I stop this service and start it again, it wont work since ... work manager is non in runnable state.
(iirc in case of reload it's masked, since reload spawn new instance of service, but stop/start will still affect this service)

On top of that. Per your comment - each service must be symetrical:
1. Stop = WM.stop();
2. Start = do nothing?

If it's supposed to be symetrical:
1. Stop = WM.stop();
2. Start = WM.start(); aka cancelShutdown()

iirc Workmanager.shutdown(); just set a 'runnable' flag to false and than just allows tasks to end their life cycle, thats it. After this code execution returns to WorkManagerService. No wait, no grace period.
The 'runnable' flag is checked when new task is submited, if false, throw exception.
WorkManager.cancelShutDown() set this flag to true ( in other word, method name is misleading)

                
> WorkManagerService does not start work manager
> ----------------------------------------------
>
>                 Key: WFLY-2215
>                 URL: https://issues.jboss.org/browse/WFLY-2215
>             Project: WildFly
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>          Components: JCA
>    Affects Versions: 8.0.0.Beta1
>            Reporter: Bartosz Baranowski
>            Assignee: Stefano Maestri
>             Fix For: 8.0.0.CR1
>
>
> WorkManagerService does not start/restart WorkManager
> https://github.com/wildfly/wildfly/blob/master/connector/src/main/java/org/jboss/as/connector/services/workmanager/WorkManagerService.java#L76
> WorkManager is set in constructor. In stop method, WorkManager.shutdown() is called. start() should invoke WorkManager.cancelShutdown().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira