[jboss-jira] [JBoss JIRA] (WFLY-2478) Infinispan subsystem test cases need updating

[Radoslav Husar (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926846#comment-12926846 ] 

Radoslav Husar commented on WFLY-2478:
--------------------------------------

BTW Are you planning to use the naming convention for the XMLs I suggested on Nov 15 ?

>> One possible file naming convention:
>>
>> jgroups-subsystem-current.xml
>> jgroups-subsystem-current-transform.xml
>> jgroups-subsystem-current-transform-reject{1,2,3,...}.xml
>> jgroups-subsystem-xsd-1.0.xml
>> jgroups-subsystem-xsd-1.1.xml
> 
> -1 to this convention.
> 
> When I tried to refactor those previously, the goals were:
> 
> * no need to include "xsd" string in the xml version -- all XMLs files 
> follow and XSD and they need not represent a model version
> * denote XSD version in all files: one would have to open the file to 
> find the XSD version, can be easier forgotten to be bumped, and current 
> would have to be renamed with every bump.
> * no dot character, use dashes instead
> * use suffix to make the name clear what is the xml file for and keep 
> files ordered:
>    - no suffix = subsystem parsing test
>    - suffix "transformer" = accepted transformations (typically 1 file 
> is enough)
>    - suffix "transformer-reject" = rejected transformations (multiple 
> needed)
> 
> So I would suggest:
> 
> <subsystem name>-subsystem-<schema version>-<suffix>.xml
> 
> that would make nicely sorted list:
> 
> - jgroups-subsystem-1_0.xml
> - jgroups-subsystem-1_1.xml
> - jgroups-subsystem-1_2.xml
> - jgroups-subsystem-1_2-transform.xml
> - jgroups-subsystem-1_2-transform-reject1.xml
> - jgroups-subsystem-1_2-transform-reject2.xml
> - jgroups-subsystem-1_2-transform-discard.xml
> 
> Cheers,
> Rado
                
> Infinispan subsystem test cases need updating
> ---------------------------------------------
>
>                 Key: WFLY-2478
>                 URL: https://issues.jboss.org/browse/WFLY-2478
>             Project: WildFly
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>          Components: Clustering
>    Affects Versions: 8.0.0.Beta1
>            Reporter: Radoslav Husar
>            Assignee: Richard Achmatowicz
>            Priority: Critical
>             Fix For: 8.0.0.CR1
>
>
> Needs clean up and update:
> InfinispanSubsystemTransformerTestCase
> * testTransformer720 is missing
> * getSubsystemXml should feed in the latest xml, so 2.0 not 1.4
> SubsystemParsingTestCase
> * seems to test 1.1. only
> * doesnt test 1.0 all the way to 2.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira