From issues at jboss.org Tue Jul 14 20:59:02 2015 From: issues at jboss.org (Arcadiy Ivanov (JIRA)) Date: Tue, 14 Jul 2015 20:59:02 -0400 (EDT) Subject: [jboss-osgi-issues] [JBoss JIRA] (JBOSGI-773) Rewrite OSGi Subsystem for domain support In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBOSGI-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on JBOSGI-773 stopped by Arcadiy Ivanov. --------------------------------------------- > Rewrite OSGi Subsystem for domain support > ----------------------------------------- > > Key: JBOSGI-773 > URL: https://issues.jboss.org/browse/JBOSGI-773 > Project: JBoss OSGi > Issue Type: Feature Request > Components: wildfly > Affects Versions: JBossOSGi 2.2.0 > Reporter: Arcadiy Ivanov > Assignee: Arcadiy Ivanov > Fix For: JBossOSGI 2.3.1 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) From issues at jboss.org Tue Jul 14 21:10:02 2015 From: issues at jboss.org (Arcadiy Ivanov (JIRA)) Date: Tue, 14 Jul 2015 21:10:02 -0400 (EDT) Subject: [jboss-osgi-issues] [JBoss JIRA] (JBOSGI-778) Centralize module OsgiMetaData reading logic In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBOSGI-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arcadiy Ivanov resolved JBOSGI-778. ----------------------------------- Resolution: Done > Centralize module OsgiMetaData reading logic > -------------------------------------------- > > Key: JBOSGI-778 > URL: https://issues.jboss.org/browse/JBOSGI-778 > Project: JBoss OSGi > Issue Type: Enhancement > Components: framework, resolver, wildfly > Reporter: Arcadiy Ivanov > Assignee: Arcadiy Ivanov > Fix For: JBossOSGI 2.3.1 > > > * Module OSGiMetaData processing is all over the place and needs to be centralized > * OSGiMetaData attachment to XBundleRevision needs to be reviewed -- This message was sent by Atlassian JIRA (v6.3.15#6346) From issues at jboss.org Tue Jul 14 23:05:02 2015 From: issues at jboss.org (Arcadiy Ivanov (JIRA)) Date: Tue, 14 Jul 2015 23:05:02 -0400 (EDT) Subject: [jboss-osgi-issues] [JBoss JIRA] (JBOSGI-780) ManifestBuilder does not work on windows if line has 511 bytes In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBOSGI-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arcadiy Ivanov reassigned JBOSGI-780: ------------------------------------- Assignee: Arcadiy Ivanov > ManifestBuilder does not work on windows if line has 511 bytes > -------------------------------------------------------------- > > Key: JBOSGI-780 > URL: https://issues.jboss.org/browse/JBOSGI-780 > Project: JBoss OSGi > Issue Type: Bug > Components: other > Environment: windows > Reporter: Martin Basovnik > Assignee: Arcadiy Ivanov > > Lines on Windows OS end with {{CRLF}} ({{\r\n}}). Method [{{org.jboss.osgi.metadata.ManifestBuilder.getManifest()}}|https://github.com/jbosgi/jbosgi-metadata/blob/master/src/main/java/org/jboss/osgi/metadata/ManifestBuilder.java#L93] does not count with this fact. If {{bytes.length == 511}} then a line will have 513 bytes and method {{Manifest#read}} will throw {{IOException}} and the building of the manifest will fail. > Reason: > The following line will crop byte {{\n}}: > {code:java} > byte[] lbuf = new byte[512]; > attr.read(fis, lbuf); > {code} > and then the following condition will fail because the value of {{lbuf\[--len\]}} expression is {{'\r'}}. > {code:java} > if (lbuf[--len] != '\n') { > throw new IOException("manifest line too long"); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) From issues at jboss.org Tue Jul 14 23:05:02 2015 From: issues at jboss.org (Arcadiy Ivanov (JIRA)) Date: Tue, 14 Jul 2015 23:05:02 -0400 (EDT) Subject: [jboss-osgi-issues] [JBoss JIRA] (JBOSGI-780) ManifestBuilder does not work on windows if line has 511 bytes In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBOSGI-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on JBOSGI-780 started by Arcadiy Ivanov. --------------------------------------------- > ManifestBuilder does not work on windows if line has 511 bytes > -------------------------------------------------------------- > > Key: JBOSGI-780 > URL: https://issues.jboss.org/browse/JBOSGI-780 > Project: JBoss OSGi > Issue Type: Bug > Components: other > Environment: windows > Reporter: Martin Basovnik > Assignee: Arcadiy Ivanov > > Lines on Windows OS end with {{CRLF}} ({{\r\n}}). Method [{{org.jboss.osgi.metadata.ManifestBuilder.getManifest()}}|https://github.com/jbosgi/jbosgi-metadata/blob/master/src/main/java/org/jboss/osgi/metadata/ManifestBuilder.java#L93] does not count with this fact. If {{bytes.length == 511}} then a line will have 513 bytes and method {{Manifest#read}} will throw {{IOException}} and the building of the manifest will fail. > Reason: > The following line will crop byte {{\n}}: > {code:java} > byte[] lbuf = new byte[512]; > attr.read(fis, lbuf); > {code} > and then the following condition will fail because the value of {{lbuf\[--len\]}} expression is {{'\r'}}. > {code:java} > if (lbuf[--len] != '\n') { > throw new IOException("manifest line too long"); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) From issues at jboss.org Wed Jul 15 00:07:02 2015 From: issues at jboss.org (Arcadiy Ivanov (JIRA)) Date: Wed, 15 Jul 2015 00:07:02 -0400 (EDT) Subject: [jboss-osgi-issues] [JBoss JIRA] (JBOSGI-780) ManifestBuilder does not work on windows if line has 511 bytes In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBOSGI-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arcadiy Ivanov updated JBOSGI-780: ---------------------------------- Git Pull Request: https://github.com/jbosgi/jbosgi-metadata/pull/4 > ManifestBuilder does not work on windows if line has 511 bytes > -------------------------------------------------------------- > > Key: JBOSGI-780 > URL: https://issues.jboss.org/browse/JBOSGI-780 > Project: JBoss OSGi > Issue Type: Bug > Components: other > Environment: windows > Reporter: Martin Basovnik > Assignee: Arcadiy Ivanov > > Lines on Windows OS end with {{CRLF}} ({{\r\n}}). Method [{{org.jboss.osgi.metadata.ManifestBuilder.getManifest()}}|https://github.com/jbosgi/jbosgi-metadata/blob/master/src/main/java/org/jboss/osgi/metadata/ManifestBuilder.java#L93] does not count with this fact. If {{bytes.length == 511}} then a line will have 513 bytes and method {{Manifest#read}} will throw {{IOException}} and the building of the manifest will fail. > Reason: > The following line will crop byte {{\n}}: > {code:java} > byte[] lbuf = new byte[512]; > attr.read(fis, lbuf); > {code} > and then the following condition will fail because the value of {{lbuf\[--len\]}} expression is {{'\r'}}. > {code:java} > if (lbuf[--len] != '\n') { > throw new IOException("manifest line too long"); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) From issues at jboss.org Wed Jul 15 00:07:02 2015 From: issues at jboss.org (Arcadiy Ivanov (JIRA)) Date: Wed, 15 Jul 2015 00:07:02 -0400 (EDT) Subject: [jboss-osgi-issues] [JBoss JIRA] (JBOSGI-780) ManifestBuilder does not work on windows if line has 511 bytes In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBOSGI-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on JBOSGI-780 stopped by Arcadiy Ivanov. --------------------------------------------- > ManifestBuilder does not work on windows if line has 511 bytes > -------------------------------------------------------------- > > Key: JBOSGI-780 > URL: https://issues.jboss.org/browse/JBOSGI-780 > Project: JBoss OSGi > Issue Type: Bug > Components: other > Environment: windows > Reporter: Martin Basovnik > Assignee: Arcadiy Ivanov > > Lines on Windows OS end with {{CRLF}} ({{\r\n}}). Method [{{org.jboss.osgi.metadata.ManifestBuilder.getManifest()}}|https://github.com/jbosgi/jbosgi-metadata/blob/master/src/main/java/org/jboss/osgi/metadata/ManifestBuilder.java#L93] does not count with this fact. If {{bytes.length == 511}} then a line will have 513 bytes and method {{Manifest#read}} will throw {{IOException}} and the building of the manifest will fail. > Reason: > The following line will crop byte {{\n}}: > {code:java} > byte[] lbuf = new byte[512]; > attr.read(fis, lbuf); > {code} > and then the following condition will fail because the value of {{lbuf\[--len\]}} expression is {{'\r'}}. > {code:java} > if (lbuf[--len] != '\n') { > throw new IOException("manifest line too long"); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) From issues at jboss.org Wed Jul 15 00:29:02 2015 From: issues at jboss.org (Arcadiy Ivanov (JIRA)) Date: Wed, 15 Jul 2015 00:29:02 -0400 (EDT) Subject: [jboss-osgi-issues] [JBoss JIRA] (JBOSGI-780) ManifestBuilder does not work on windows if line has 511 bytes In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBOSGI-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arcadiy Ivanov resolved JBOSGI-780. ----------------------------------- Fix Version/s: JBossOSGI 2.3.1 Resolution: Done > ManifestBuilder does not work on windows if line has 511 bytes > -------------------------------------------------------------- > > Key: JBOSGI-780 > URL: https://issues.jboss.org/browse/JBOSGI-780 > Project: JBoss OSGi > Issue Type: Bug > Components: other > Environment: windows > Reporter: Martin Basovnik > Assignee: Arcadiy Ivanov > Fix For: JBossOSGI 2.3.1 > > > Lines on Windows OS end with {{CRLF}} ({{\r\n}}). Method [{{org.jboss.osgi.metadata.ManifestBuilder.getManifest()}}|https://github.com/jbosgi/jbosgi-metadata/blob/master/src/main/java/org/jboss/osgi/metadata/ManifestBuilder.java#L93] does not count with this fact. If {{bytes.length == 511}} then a line will have 513 bytes and method {{Manifest#read}} will throw {{IOException}} and the building of the manifest will fail. > Reason: > The following line will crop byte {{\n}}: > {code:java} > byte[] lbuf = new byte[512]; > attr.read(fis, lbuf); > {code} > and then the following condition will fail because the value of {{lbuf\[--len\]}} expression is {{'\r'}}. > {code:java} > if (lbuf[--len] != '\n') { > throw new IOException("manifest line too long"); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) From issues at jboss.org Thu Jul 16 15:19:02 2015 From: issues at jboss.org (Arcadiy Ivanov (JIRA)) Date: Thu, 16 Jul 2015 15:19:02 -0400 (EDT) Subject: [jboss-osgi-issues] [JBoss JIRA] (JBOSGI-773) Rewrite OSGi Subsystem for domain support In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBOSGI-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arcadiy Ivanov updated JBOSGI-773: ---------------------------------- Fix Version/s: (was: JBossOSGI 2.3.1) > Rewrite OSGi Subsystem for domain support > ----------------------------------------- > > Key: JBOSGI-773 > URL: https://issues.jboss.org/browse/JBOSGI-773 > Project: JBoss OSGi > Issue Type: Feature Request > Components: wildfly > Affects Versions: JBossOSGi 2.2.0 > Reporter: Arcadiy Ivanov > Assignee: Arcadiy Ivanov > -- This message was sent by Atlassian JIRA (v6.3.15#6346)