[jboss-remoting-commits] JBoss Remoting SVN: r5298 - remoting2/branches/2.2.3-hangfix/src/main/org/jboss/remoting/marshal/serializable.

[jboss-remoting-commits at lists.jboss.org]

Author: david.lloyd at jboss.com
Date: 2009-06-16 19:18:28 -0400 (Tue, 16 Jun 2009)
New Revision: 5298

Modified:
   remoting2/branches/2.2.3-hangfix/src/main/org/jboss/remoting/marshal/serializable/SerializableUnMarshaller.java
Log:
Using a BufferedInputStream in front of a blocking socket *might* cause hanging at inopportune moments, due to the fill() method not being satisfied, which may result in small initial read()s blocking when there is actually some data available.  Hopefully the possible performance impact is not significant - if it is, there is an alternate NIO-based solution possible but it is quite a bit more complex....... dot dot dot....

Modified: remoting2/branches/2.2.3-hangfix/src/main/org/jboss/remoting/marshal/serializable/SerializableUnMarshaller.java
===================================================================
--- remoting2/branches/2.2.3-hangfix/src/main/org/jboss/remoting/marshal/serializable/SerializableUnMarshaller.java	2009-06-16 23:16:24 UTC (rev 5297)
+++ remoting2/branches/2.2.3-hangfix/src/main/org/jboss/remoting/marshal/serializable/SerializableUnMarshaller.java	2009-06-16 23:18:28 UTC (rev 5298)
@@ -67,9 +67,8 @@
       }
       else
       {
-         BufferedInputStream bis = new BufferedInputStream(inputStream);
          SerializationManager manager = SerializationStreamFactory.getManagerInstance(getSerializationType());
-         return manager.createInput(bis, customClassLoader);
+         return manager.createInput(inputStream, customClassLoader);
       }
       
    }