[jboss-remoting-issues] [JBoss JIRA] Commented: (JBREM-1070) Fix deadlock in ConnectionValidator

[Ron Sigal (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBREM-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12444165#action_12444165 ] 

Ron Sigal commented on JBREM-1070:
----------------------------------

Changed synchronization on "lock" to avoid problem.

Changes applied to branches 2.2 and 2.x.

Unit test:  org.jboss.test.remoting.connection.deadlock.DeadlockTestCase


> Fix deadlock in ConnectionValidator
> -----------------------------------
>
>                 Key: JBREM-1070
>                 URL: https://jira.jboss.org/jira/browse/JBREM-1070
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.2.2.SP10, 2.5.0.SP2 (Flounder) 
>            Reporter: Ron Sigal
>            Assignee: Ron Sigal
>             Fix For: 2.2.2.SP11, 2.5.0.SP3 (Flounder)
>
>
> org.jboss.remoting.ConnectionValidator.run() synchronizes on the "lock" variable, which is needed by notifyListeners() in the event of a network failure.  In general, the calls in run() to either doCheckConnectionWithLease() or doCheckConnectionWithoutLease() should time out so that run() gives up the "lock" variable, but, if run() executes again soon enough, it can grab "lock" again before notifyListeners() can run.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira