[jboss-remoting-issues] [JBoss JIRA] Commented: (JBREM-957) faulty logging: ...transport.http.ssl.HTTPSClientInvoker.createSocketFactory logs an error when there is no error

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-957?page=comments#action_12416387 ] 
            
Ron Sigal commented on JBREM-957:
---------------------------------

This issue is more or less obsolete as of JBREM-912 "Remove stacktrace when SSLSocketBuilder.createSSLSocketFactory() fails", since the line

         log.error("Error creating SSL Socket Factory for client invoker.", e);

has been changed to

         log.warn("Unable to create SSL Socket Factory for client invoker: " + e.getMessage());
         log.debug("Unable to create SSL Socket Factory for client invoker.", e);

However, I'd like to understand how the lines

         SSLSocketBuilder server = new SSLSocketBuilder(configuration);
         server.setUseSSLSocketFactory(false);
         sf = server.createSSLSocketFactory();

are failing and what "misleading" information is getting logged,  Is there something else that needs to be fixed?

Larry, if you're still watching, can you elaborate?

Thanks.

> faulty logging: ...transport.http.ssl.HTTPSClientInvoker.createSocketFactory logs an error when there is no error
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: JBREM-957
>                 URL: http://jira.jboss.com/jira/browse/JBREM-957
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>         Environment: 2.2.0.GA as included in JBoss-4.2.2.GA
>            Reporter: Larry Talley
>         Assigned To: Ron Sigal
>             Fix For: 2.2.2.SP8
>
>
> When used in client mode ...transport.http.ssl.HTTPSClientInvoker.createSocketFactory(HTTPSClientInvoker.java:140) logs an error, but then proceeds to work fine (because sf already has a valid value due to line 129).  The misreported error spews misleading information in the log.  I suggest that line 144 shouldn't be at ERROR level if the IOException isn't always an error.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira