[jboss-remoting-issues] [JBoss JIRA] Resolved: (JBREM-1055) ConnectionValidator.run() should have a sanity test to prevent calls from application code

[Trustin Lee (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBREM-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trustin Lee resolved JBREM-1055.
--------------------------------

    Resolution: Done
      Assignee: Trustin Lee  (was: Ron Sigal)


I've checked in the patch and its related test case.  It was somewhat difficult to add a pure unit test case but it seemed to work with a couple dummy parameters.  :)

> ConnectionValidator.run() should have a sanity test to prevent calls from application code
> ------------------------------------------------------------------------------------------
>
>                 Key: JBREM-1055
>                 URL: https://jira.jboss.org/jira/browse/JBREM-1055
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.2.2.SP10, 2.5.0.SP1 (Flounder)
>            Reporter: Ron Sigal
>            Assignee: Trustin Lee
>            Priority: Minor
>             Fix For: 2.2.2.SP11, 2.5.0.SP2 (Flounder) 
>
>         Attachments: patch.txt
>
>
> org.jboss.remoting.ConnectionValidator extends java.util.TimerTask which implements Runnable and has a public run() class.  run() needs to be public so it can be called by java.util.Timer, but it also exposes the method to application code, which can lead to a NullPointerException if run() is called directly.  There should be a log message to deter a direct call.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira