[jboss-remoting-issues] [JBoss JIRA] Commented: (JBREM-1121) Client SocketFactory should be configurable by InvokerLocator

[Ron Sigal (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBREM-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12463330#action_12463330 ] 

Ron Sigal commented on JBREM-1121:
----------------------------------

org.jboss.remoting.RemoteClientInvoker now uses the new constant org.jboss.remoting.Remoting.USE_ALL_SOCKET_FACTORY_PARAMS (actual value "useAllSocketFactoryParams") to determine whether it should pass just the configuration map or the combination of configuration map and InvokerLocator parameters to org.jboss.remoting.AbstractInvoker.createSocketFactory().

Note that the "combination of configuration map and InvokerLocator" is created by the AbstractInvoker constructor and is affected by the value, if any, of Remoting.CONFIG_OVERRIDES_LOCATOR (actual value "configOverridesLocator"), as described in JBREM-1124 "Invokers need option for configuration map parameters to override InvokerLocator parameters".

Changes added to 2.x branch.

Unit tests:

  * org.jboss.test.remoting.socketfactory.UseAllSocketFactoryParamsTestCase

  * also, added methods to org.jboss.test.remoting.socketfactory.SocketFactoryClassNameTestRoot, created for JBREM-1015 "CLONE [JBREM-1014] - Support injection of socket factory class name into AbstractInvoker", to verify that adding Remoting.USE_ALL_SOCKET_FACTORY_PARAMS doesn't interfere with the functionality introduced in JBREM-1015.

Waiting for results in hudson.

> Client SocketFactory should be configurable by InvokerLocator
> -------------------------------------------------------------
>
>                 Key: JBREM-1121
>                 URL: https://jira.jboss.org/jira/browse/JBREM-1121
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.2.2.SP11, 2.5.1 (Flounder)
>            Reporter: Ron Sigal
>            Assignee: Ron Sigal
>             Fix For: 2.2.2.SP12, 2.5.2 (Flounder)
>
>
> org.jboss.remoting.RemoteClientInvoker, which creates the client invoker's SocketFactory, uses only the parameters passed in the configuration map (except for looking in the InvokerLocator for org.jboss.remoting.SOCKET_FACTORY_CLASS_NAME (actual value "socketFactoryClassName"), which was introduced in JBREM-1014 "Support injection of socket factory class name into AbstractInvoker").  There should be a configurable option to use all parameters from the InvokerLocator.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira