[jboss-remoting-issues] [JBoss JIRA] Commented: (JBREM-1081) Fix NPE in ServerInvokerCallbackHandler

[Ron Sigal (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBREM-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12458326#action_12458326 ] 

Ron Sigal commented on JBREM-1081:
----------------------------------

ServerInvokerCallbackHandler.destroy() no longer sets callBackClient and callbackClient to null.  Changes have been applied to 2.2 and 2.x branches.

Unit test: org.jboss.test.remoting.callback.DestroyNPETestCase.

Will wait for results from Hudson.

> Fix NPE in ServerInvokerCallbackHandler 
> ----------------------------------------
>
>                 Key: JBREM-1081
>                 URL: https://jira.jboss.org/jira/browse/JBREM-1081
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.5.0.SP2 (Flounder) , 2.2.2.SP11
>            Reporter: Ron Sigal
>            Assignee: Ron Sigal
>            Priority: Minor
>             Fix For: 2.5.0.SP3 (Flounder), 2.2.2.SP12
>
>
> When org.jboss.remoting.callback.ServerInvokerCallback is shut down by a call to ServerInvokerCallbackHandler.destroy(), the variables callBackClient and callbackStore are set to null.  If ServerInvokerCallbackHandler.handleCallback() is called subsequently (which can happen if destroy() is called by ServerInvokerCallbackHandler.handleConnectionException() and the application has not yet been informed about a connection failure), then, since callbackClient == null, it looks like pull callbacks are configured, but, since callbackStore == null, a NullPointerException is thrown in ServerInvokerCallbackHandler.persistCallback().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira