[jboss-remoting-issues] [JBoss JIRA] Created: (JBREM-1166) Possible race condition in ConnectionValidator

[Takayoshi Kimura (JIRA)]

Possible race condition in ConnectionValidator
----------------------------------------------

                 Key: JBREM-1166
                 URL: https://jira.jboss.org/jira/browse/JBREM-1166
             Project: JBoss Remoting
          Issue Type: Bug
      Security Level: Public (Everyone can see)
    Affects Versions: 2.2.3.SP1, 2.2.3
            Reporter: Takayoshi Kimura
             Fix For: 2.2.3.SP2


The 2.2.3 has a minor regression. The ConnectionValidator#start() has been moved outside of synchronized block in this release, this leads a race condition problem.

ConnectionValidator#start():
 TimerUtil.schedule(this, pingPeriod); // will call ConnectionValidator.run()
 timer = new Timer(true); // is used in ConnectionValidator.run()

These 2 lines looks odd, because it initializes the timer for new thread after spawn the thread. In 2.2.2-SP11 the timer variable is protected by synchronized blocks, so it's not the case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira