[jboss-remoting-issues] [JBoss JIRA] Commented: (JBREM-1164) Remoting shouldn't require IPv6 addresses to be surrounded by brackets

Richard Achmatowicz (JIRA) jira-events at lists.jboss.org
Fri Oct 16 11:35:05 EDT 2009


    [ https://jira.jboss.org/jira/browse/JBREM-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12490182#action_12490182 ] 

Richard Achmatowicz commented on JBREM-1164:
--------------------------------------------

1. The -b command-line parameter gets substituted into the system property jboss.bind_address.
Many Connector MBeans construct their InvokerLocator URL by simply substituting $jboss.bind_address into a URL string, like this:

  <bean name="org.jboss.ejb3.RemotingConnector" class="org.jboss.remoting.transport.Connector">
    <property name="invokerLocator">
      <value-factory bean="ServiceBindingManager" method="getStringBinding">
        <parameter> jboss.remoting:type=Connector,name=DefaultEjb3Connector,handler=ejb3</parameter>
        <parameter><null /></parameter>
        <parameter>socket://${jboss.bind.address}:${port}</parameter>
        <parameter><null /></parameter>
        <parameter>3873</parameter>
      </value-factory>
    </property>
    <property name="serverConfiguration"><inject bean="ServerConfiguration" /></property>
  </bean>

The InvokerLocator is then initialised with the URL socket://${jboss.bind.address}:${port}.

2. The InvokerLocator has a constuctor InvokerLocator(String uri) which takes a URI string and does one of two things:
(i) parses the URI using the URI constructor, plus a few pieces of magic
(ii) parses the URI using a legacy parsing algorithm

The URI constructor assumes that if the URI invoves a IPv6 host name, that the hostname is enclosed in brackets. If the hostname is not enclosed in brackets, it does not throw a URISyntaxException (which I would have hoped) but instead returns host == null, port == -1.
The legacy parsing code does not handle IPv6 addresses, from what I can see, based on how it deals with colons.








> Remoting shouldn't require IPv6 addresses to be surrounded by brackets
> ----------------------------------------------------------------------
>
>                 Key: JBREM-1164
>                 URL: https://jira.jboss.org/jira/browse/JBREM-1164
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.5.2 (Flounder)
>            Reporter: Ron Sigal
>            Assignee: Ron Sigal
>             Fix For: 2.5.2.SP1 (Flounder)
>
>
> Although IPv6 addresses are surrounded by brackets in URLs, the addresses themselves don't have brackets.  Thus, it should be possible to start the Application Server with
>    run.sh -b ::1
> instead of requiring
>    run.sh -b [::1]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jboss-remoting-issues mailing list