[jboss-remoting-issues] [JBoss JIRA] Commented: (JBREM-1150) Lease should update client list if PING invocation has same time as previous PING

Ron Sigal (JIRA) jira-events at lists.jboss.org
Wed Sep 2 21:52:23 EDT 2009


    [ https://jira.jboss.org/jira/browse/JBREM-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12484284#action_12484284 ] 

Ron Sigal commented on JBREM-1150:
----------------------------------

Applied change to branches 2.2 and 2.x.

Testing:  No new unit test is necessary.  The bug was discovered because of the failure of existing test org.jboss.test.remoting.lease.InjectedConnectionListenerTestCase.

> Lease should update client list if PING invocation has same time as previous PING
> ---------------------------------------------------------------------------------
>
>                 Key: JBREM-1150
>                 URL: https://jira.jboss.org/jira/browse/JBREM-1150
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.5.1 (Flounder), 2.2.3
>            Reporter: Ron Sigal
>            Assignee: Ron Sigal
>             Fix For: 2.5.2 (Flounder), 2.2.3.SP1
>
>
> When an org.jboss.remoting.lease is created, in response to org.jboss.remoting.MicroRemotingClientInvoker sending a PING,  it has no clients.  The next PING invocation, generated by org.jboss.remoting.LeasePinger.addClient(), supplies a list of clients.  However, Lease updates its client list only if the timestamp in the InvocationRequest is greater than the timestamp of the previous InvocationRequest.  Since the two PINGs that create a Lease could have the same timestamp, the test in Lease should be >= instead of >.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jboss-remoting-issues mailing list