[jboss-remoting-issues] [JBoss JIRA] Commented: (JBREM-1154) Client.connect() should throw an exception when Lease creation fails

[Ron Sigal (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBREM-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12485507#action_12485507 ] 

Ron Sigal commented on JBREM-1154:
----------------------------------

The changes made for this issue broke some unit tests:

  * org.jboss.test.remoting.lease.timeout.UniquePingerTaskTestCase
  * org.jboss.test.remoting.lease.timeout.LeasePingerTimeoutTestCase

These have been fixed.

> Client.connect() should throw an exception when Lease creation fails
> --------------------------------------------------------------------
>
>                 Key: JBREM-1154
>                 URL: https://jira.jboss.org/jira/browse/JBREM-1154
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.5.1 (Flounder), 2.2.3
>            Reporter: Ron Sigal
>            Assignee: Ron Sigal
>             Fix For: 2.5.2 (Flounder), 2.2.3.SP1
>
>
> When any of the versions of org.jboss.remoting.Client.connect() is called, it will try, if leasing is enabled, to register the Client with an org.jboss.remoting.Lease on the server side.  Client.connect() calls org.jboss.remoting.MicroRemoteClientInvoker.establishLease(), which calls org.jboss.remoting.LeasePinger.addClient(), which calls LeasePinger.sendClientPing(), which sends to the server the Clients it represents.  If LeasePinger.sendClientPing() fails, it just logs a message and swallows the exception.  That behavior is appropriate when sendClientPing() is just sending an ordinary PING, but if the attempt to register a new Client fails, the call to Client.connect() should fail.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira