[jboss-remoting-issues] [JBoss JIRA] Commented: (JBREM-1185) Change use of == to String.equals() in SSLSocketBuilder.validateStoreURL()

[Ron Sigal (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBREM-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12514577#action_12514577 ] 

Ron Sigal commented on JBREM-1185:
----------------------------------

Changed the test from 

      if (storePath == NONE_STORE)

to

      if (NONE_STORE.equals(storePath))

on branches 2.2 and 2.x.

Testing:

Added testDistinctNONEKeyStore() to org.jboss.test.remoting.ssl.emptyStore.EmptyStoreTestCase.

Waiting for hudson results.

> Change use of == to String.equals() in SSLSocketBuilder.validateStoreURL()
> --------------------------------------------------------------------------
>
>                 Key: JBREM-1185
>                 URL: https://jira.jboss.org/jira/browse/JBREM-1185
>             Project: JBoss Remoting
>          Issue Type: Sub-task
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.2.3.SP1, 2.5.2.SP2 (Flounder)
>            Reporter: Ron Sigal
>            Assignee: Ron Sigal
>             Fix For: 2.2.3.SP2, 2.5.2.SP3 (Flounder)
>
>
> org.jboss.remoting.security.SSLSocketBuilder.validateStoreURL() compares two Strings using ==.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira