[jboss-remoting-issues] [JBoss JIRA] Commented: (JBREM-1234) Avoid excessive calls to InetAddress.getLocalHost()

[Ron Sigal (JIRA)]

    [ https://jira.jboss.org/browse/JBREM-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12540600#action_12540600 ] 

Ron Sigal commented on JBREM-1234:
----------------------------------

Changed all instances of InetAddress.getLocalHost() (except those in samples and tests) to use the value of localhost obtained in a static block.

There are no special unit tests.

Waiting for results in hudson.

> Avoid excessive calls to InetAddress.getLocalHost()
> ---------------------------------------------------
>
>                 Key: JBREM-1234
>                 URL: https://jira.jboss.org/browse/JBREM-1234
>             Project: JBoss Remoting
>          Issue Type: Quality Risk
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.5.3 (Flounder) 
>            Reporter: Ron Sigal
>            Assignee: Ron Sigal
>             Fix For: 2.5.3.SP1
>
>
> From JBPAPP-4617 "Possible performance issue in Remoting":
> JMS remote connections that are used locally result in a lot of calls to InetAddress.getLocalHost() which for some reason is slow. 
> Why not:
>    private static final InetAddress LOCAL_HOST;
>    static
>    {
>       try
>       {
>          LOCAL_HOST = InetAddress.getLocalHost();
>       }
>       catch (UnknownHostException e)
>       {
>          throw new ExceptionInInitializerError(e);
>       }
>    }
>    private static InetAddress getLocalHost() throws UnknownHostException
>    {
>       return LOCAL_HOST;
>    }
> Which is roughly 1000x faster. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira