[jboss-remoting-issues] [JBoss JIRA] Commented: (JBREM-1282) ServerInvoker does not close StreamHandler in the case of "addstreamcallback"

Ron Sigal (JIRA) jira-events at lists.jboss.org
Wed Apr 20 00:05:33 EDT 2011


    [ https://issues.jboss.org/browse/JBREM-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596654#comment-12596654 ] 

Ron Sigal commented on JBREM-1282:
----------------------------------

I don't think it's appropriate for ServerInvoker to close the StreamHandler, since the StreamInvocationHandler application code might want to continue reading from the stream on another thread.  Actually, the StreamInvocationHandler should close the StreamHandler.  But a quick inspection of org.jboss.deployment.services.DeploymentManagerService, which accesses the StreamHandler, suggests that the StreamHandler is, in fact, being closed.  I'll have to take a closer look.

> ServerInvoker does not close StreamHandler in the case of "addstreamcallback"
> -----------------------------------------------------------------------------
>
>                 Key: JBREM-1282
>                 URL: https://issues.jboss.org/browse/JBREM-1282
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.5.4.SP1, 2.2.4
>            Reporter: Ramesh Reddy
>            Assignee: Ron Sigal
>             Fix For: 2.5.4.SP2, 2.2.4.SP1
>
>         Attachments: JBossRemoting.patch
>
>
> This started out http://community.jboss.org/thread/163742 and in Teiid project we created a JIRA for this https://issues.jboss.org/browse/TEIID-1511
> while debugging for this issue, I found that in ServerInvoker, for "AddStreamCallback" block in the "handleInternalInvocation" method it does not close the stream handler once it is done. This results in open socket connection. I am not sure if this connection closes after some idle time, but in our case user is rapidly going through deploy and undeploy action, results in too many open files. I created a patch and tested with our usecase, the problem no longer exists. Please find attached patch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jboss-remoting-issues mailing list