[jboss-remoting-issues] [JBoss JIRA] Commented: (JBREM-1283) CLONE [JBREM-1281] - Support setting executor in CoyoteInvoker

[Ron Sigal (JIRA)]

    [ https://issues.jboss.org/browse/JBREM-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599966#comment-12599966 ] 

Ron Sigal commented on JBREM-1283:
----------------------------------

org.jboss.remoting.transport.coyote.CoyoteInvoker has been updated to be compatible with jbossweb, which is based on tomcat 6.

CoyoteInvoker.setup() will, as always, scan the configuration map and call CoyoteInvoker.setProperty() for each entry to set the appropriate property on the ProtocolHandler. However, when it encounters a property named "executor", it will parse the String value, expecting a String of the form "name1=value1, ..., nameN=valueN", to create a property map. It will create a org.apache.catalina.core.StandardThreadExecutor, apply the properties in the new property map to the StandardThreadExecutor, and call setExecutor() on the ProtocolHandler with the StandardThreadExecutor.

If the value of "executor" is to be set in a *-service.xml file, it would look like

<attribute name="Configuration">
<config>
<invoker transport="http">
...
<attribute name="executor">minSpareThreads=20,maxThreads=100</attribute>
...
</invoker>
...
</config>
</attribute>


> CLONE [JBREM-1281] - Support setting executor in CoyoteInvoker
> --------------------------------------------------------------
>
>                 Key: JBREM-1283
>                 URL: https://issues.jboss.org/browse/JBREM-1283
>             Project: JBoss Remoting
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.5.4.SP1
>            Reporter: Justin Bertram
>            Assignee: Ron Sigal
>             Fix For: 2.5.4.SP2
>
>
> In Tomcat 5.5 org.apache.coyote.http11.Http11Protocol [1] inherited its getters and setters from org.apache.coyote.http11.Http11BaseProtocol [2] and one could set "minSpareThreads" and "maxSpareThreads" directly.  However, in Tomcat 6.0 [3] there is a new setExecutor method which takes a java.util.concurrent.Executor (i.e. not a String or a primitive like the other setters).  The org.jboss.remoting.transport.coyote.CoyoteInvoker.setProperty(..) method doesn't support this.
> [1] http://tomcat.apache.org/tomcat-5.5-doc/catalina/docs/api/org/apache/coyote/http11/Http11Protocol.html
> [2] http://tomcat.apache.org/tomcat-5.5-doc/catalina/docs/api/org/apache/coyote/http11/Http11BaseProtocol.html
> [3] http://tomcat.apache.org/tomcat-6.0-doc/api/org/apache/coyote/http11/Http11Protocol.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira