From issues at jboss.org Wed Dec 10 23:28:39 2014 From: issues at jboss.org (Ron Sigal (JIRA)) Date: Wed, 10 Dec 2014 23:28:39 -0500 (EST) Subject: [jboss-remoting-issues] [JBoss JIRA] (JBREM-1328) LeasePinger should not use a static Timer In-Reply-To: References: Message-ID: Ron Sigal created JBREM-1328: -------------------------------- Summary: LeasePinger should not use a static Timer Key: JBREM-1328 URL: https://issues.jboss.org/browse/JBREM-1328 Project: JBoss Remoting Issue Type: Bug Affects Versions: 2.5.4.SP5 Reporter: Ron Sigal Assignee: Ron Sigal Fix For: 2.5.4.SP6 org.jboss.remoting.LeasePinger currently uses a static Timer. If one LeasePinger gets hung up waiting for a response, it can prevent another LeasePinger from sending a PING, leading to a broken Lease on the server. -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 23:34:39 2014 From: issues at jboss.org (Ron Sigal (JIRA)) Date: Wed, 10 Dec 2014 23:34:39 -0500 (EST) Subject: [jboss-remoting-issues] [JBoss JIRA] (JBREM-1329) Reused ConnectionValidator can hold a reference to a disconnected Client In-Reply-To: References: Message-ID: Ron Sigal created JBREM-1329: -------------------------------- Summary: Reused ConnectionValidator can hold a reference to a disconnected Client Key: JBREM-1329 URL: https://issues.jboss.org/browse/JBREM-1329 Project: JBoss Remoting Issue Type: Bug Affects Versions: 2.5.4.SP5 Reporter: Ron Sigal Assignee: Ron Sigal Fix For: 2.5.4.SP6 Instances of org.jboss.remoting.ConnectionValidator hold a reference to an org.jboss.remoting.Client, from which it obtains the value of clientLeasePeriod. If the ConnectionValidator is being reused, and the Client it points to has been disconnected, it gets a value of -1 and it doesn't tie pinging to a Lease. -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 23:54:39 2014 From: issues at jboss.org (Ron Sigal (JIRA)) Date: Wed, 10 Dec 2014 23:54:39 -0500 (EST) Subject: [jboss-remoting-issues] [JBoss JIRA] (JBREM-1327) Fix synchronization in BlockingCallbackStore In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBREM-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026919#comment-13026919 ] Ron Sigal commented on JBREM-1327: ---------------------------------- Changes committed to https://svn.jboss.org/repos/jbossremoting/remoting2/branches/2.x > Fix synchronization in BlockingCallbackStore > -------------------------------------------- > > Key: JBREM-1327 > URL: https://issues.jboss.org/browse/JBREM-1327 > Project: JBoss Remoting > Issue Type: Bug > Affects Versions: 2.5.4.SP5 > Reporter: Ron Sigal > Assignee: Ron Sigal > Fix For: 2.5.4.SP6 > > > In org.jboss.remoting.callback.BlockingCallbackStore, add() waits on a lock which is released only when getNext() is called. so a second Callback can be added only after the first is removed. -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 23:54:39 2014 From: issues at jboss.org (Ron Sigal (JIRA)) Date: Wed, 10 Dec 2014 23:54:39 -0500 (EST) Subject: [jboss-remoting-issues] [JBoss JIRA] (JBREM-1328) LeasePinger should not use a static Timer In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBREM-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026920#comment-13026920 ] Ron Sigal commented on JBREM-1328: ---------------------------------- Change committed to https://svn.jboss.org/repos/jbossremoting/remoting2/branches/2.x > LeasePinger should not use a static Timer > ----------------------------------------- > > Key: JBREM-1328 > URL: https://issues.jboss.org/browse/JBREM-1328 > Project: JBoss Remoting > Issue Type: Bug > Affects Versions: 2.5.4.SP5 > Reporter: Ron Sigal > Assignee: Ron Sigal > Fix For: 2.5.4.SP6 > > > org.jboss.remoting.LeasePinger currently uses a static Timer. If one LeasePinger gets hung up waiting for a response, it can prevent another LeasePinger from sending a PING, leading to a broken Lease on the server. -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Wed Dec 10 23:55:39 2014 From: issues at jboss.org (Ron Sigal (JIRA)) Date: Wed, 10 Dec 2014 23:55:39 -0500 (EST) Subject: [jboss-remoting-issues] [JBoss JIRA] (JBREM-1329) Reused ConnectionValidator can hold a reference to a disconnected Client In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBREM-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026921#comment-13026921 ] Ron Sigal commented on JBREM-1329: ---------------------------------- ConnectionValidator gets value of clientLeasePeriod at creation, instead of reference to a Client. Changes committed to https://svn.jboss.org/repos/jbossremoting/remoting2/branches/2.x > Reused ConnectionValidator can hold a reference to a disconnected Client > ------------------------------------------------------------------------ > > Key: JBREM-1329 > URL: https://issues.jboss.org/browse/JBREM-1329 > Project: JBoss Remoting > Issue Type: Bug > Affects Versions: 2.5.4.SP5 > Reporter: Ron Sigal > Assignee: Ron Sigal > Fix For: 2.5.4.SP6 > > > Instances of org.jboss.remoting.ConnectionValidator hold a reference to an org.jboss.remoting.Client, from which it obtains the value of clientLeasePeriod. If the ConnectionValidator is being reused, and the Client it points to has been disconnected, it gets a value of -1 and it doesn't tie pinging to a Lease. -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Thu Dec 11 00:04:39 2014 From: issues at jboss.org (Ron Sigal (JIRA)) Date: Thu, 11 Dec 2014 00:04:39 -0500 (EST) Subject: [jboss-remoting-issues] [JBoss JIRA] (JBREM-1330) Lease$LeaseTimerTask has a race condition In-Reply-To: References: Message-ID: Ron Sigal created JBREM-1330: -------------------------------- Summary: Lease$LeaseTimerTask has a race condition Key: JBREM-1330 URL: https://issues.jboss.org/browse/JBREM-1330 Project: JBoss Remoting Issue Type: Bug Affects Versions: 2.5.4.SP5 Reporter: Ron Sigal Assignee: Ron Sigal Fix For: 2.5.4.SP6 org.jboss.remoting.Lease$LeasePinger and org.jboss.remoting.ServerInvoker both access the map of existing Leases. -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Thu Dec 11 00:06:39 2014 From: issues at jboss.org (Ron Sigal (JIRA)) Date: Thu, 11 Dec 2014 00:06:39 -0500 (EST) Subject: [jboss-remoting-issues] [JBoss JIRA] (JBREM-1330) Lease$LeaseTimerTask has a race condition In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBREM-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026922#comment-13026922 ] Ron Sigal commented on JBREM-1330: ---------------------------------- Lease$LeaseTimerTask synchronizes access to client leases. Change committed to https://svn.jboss.org/repos/jbossremoting/remoting2/branches/2.x > Lease$LeaseTimerTask has a race condition > ----------------------------------------- > > Key: JBREM-1330 > URL: https://issues.jboss.org/browse/JBREM-1330 > Project: JBoss Remoting > Issue Type: Bug > Affects Versions: 2.5.4.SP5 > Reporter: Ron Sigal > Assignee: Ron Sigal > Fix For: 2.5.4.SP6 > > > org.jboss.remoting.Lease$LeasePinger and org.jboss.remoting.ServerInvoker both access the map of existing Leases. -- This message was sent by Atlassian JIRA (v6.3.8#6338)