From issues at jboss.org Wed Nov 19 23:40:39 2014 From: issues at jboss.org (Ron Sigal (JIRA)) Date: Wed, 19 Nov 2014 23:40:39 -0500 (EST) Subject: [jboss-remoting-issues] [JBoss JIRA] (JBREM-1327) Fix synchronization in BlockingCallbackStore In-Reply-To: References: Message-ID: Ron Sigal created JBREM-1327: -------------------------------- Summary: Fix synchronization in BlockingCallbackStore Key: JBREM-1327 URL: https://issues.jboss.org/browse/JBREM-1327 Project: JBoss Remoting Issue Type: Bug Affects Versions: 2.5.4.SP5 Reporter: Ron Sigal Assignee: Ron Sigal Fix For: 2.5.4.SP6 In org.jboss.remoting.callback.BlockingCallbackStore, add() waits on a lock which is released only when getNext() is called. so a second Callback can be added only after the first is removed. -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Thu Nov 20 03:15:40 2014 From: issues at jboss.org (Ron Sigal (JIRA)) Date: Thu, 20 Nov 2014 03:15:40 -0500 (EST) Subject: [jboss-remoting-issues] [JBoss JIRA] (JBREM-1327) Fix synchronization in BlockingCallbackStore In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBREM-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021419#comment-13021419 ] Ron Sigal edited comment on JBREM-1327 at 11/20/14 3:15 AM: ------------------------------------------------------------ Added configuration parameter org.jboss.remoting.callback.ServerInvokerCallbackHandler.CALLBACK_STORE_MAX_SIZE (actual value "callbackStoreMaxSize"), which determines the number of Callbacks that can be held by org.jboss.remoting.callback.BlockingCallbackStore before add() blocks, waiting for getNext() to remove a Callback. Default value is 10000. Testing: org.jboss.test.remoting.callback.pull.memory.blocking.BlockingCallbackStoreSynchronizationTestCase. Changes committed to https://svn.jboss.org/repos/jbossremoting/remoting2/branches/2.5.4.SP4-01241076 was (Author: ron_sigal): Added configuration parameter org.jboss.remoting.callback.ServerInvokerCallbackHandler.CALLBACK_STORE_MAX_SIZE (actual value "callbackStoreMaxSize"), which determines the number of Callbacks can be held by org.jboss.remoting.callback.BlockingCallbackStore before add() blocks, waiting for getNext() to remove a Callback. Default value is 10000. Testing: org.jboss.test.remoting.callback.pull.memory.blocking.BlockingCallbackStoreSynchronizationTestCase. Changes committed to https://svn.jboss.org/repos/jbossremoting/remoting2/branches/2.5.4.SP4-01241076 > Fix synchronization in BlockingCallbackStore > -------------------------------------------- > > Key: JBREM-1327 > URL: https://issues.jboss.org/browse/JBREM-1327 > Project: JBoss Remoting > Issue Type: Bug > Affects Versions: 2.5.4.SP5 > Reporter: Ron Sigal > Assignee: Ron Sigal > Fix For: 2.5.4.SP6 > > > In org.jboss.remoting.callback.BlockingCallbackStore, add() waits on a lock which is released only when getNext() is called. so a second Callback can be added only after the first is removed. -- This message was sent by Atlassian JIRA (v6.3.8#6338) From issues at jboss.org Thu Nov 20 03:15:40 2014 From: issues at jboss.org (Ron Sigal (JIRA)) Date: Thu, 20 Nov 2014 03:15:40 -0500 (EST) Subject: [jboss-remoting-issues] [JBoss JIRA] (JBREM-1327) Fix synchronization in BlockingCallbackStore In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/JBREM-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021419#comment-13021419 ] Ron Sigal commented on JBREM-1327: ---------------------------------- Added configuration parameter org.jboss.remoting.callback.ServerInvokerCallbackHandler.CALLBACK_STORE_MAX_SIZE (actual value "callbackStoreMaxSize"), which determines the number of Callbacks can be held by org.jboss.remoting.callback.BlockingCallbackStore before add() blocks, waiting for getNext() to remove a Callback. Default value is 10000. Testing: org.jboss.test.remoting.callback.pull.memory.blocking.BlockingCallbackStoreSynchronizationTestCase. Changes committed to https://svn.jboss.org/repos/jbossremoting/remoting2/branches/2.5.4.SP4-01241076 > Fix synchronization in BlockingCallbackStore > -------------------------------------------- > > Key: JBREM-1327 > URL: https://issues.jboss.org/browse/JBREM-1327 > Project: JBoss Remoting > Issue Type: Bug > Affects Versions: 2.5.4.SP5 > Reporter: Ron Sigal > Assignee: Ron Sigal > Fix For: 2.5.4.SP6 > > > In org.jboss.remoting.callback.BlockingCallbackStore, add() waits on a lock which is released only when getNext() is called. so a second Callback can be added only after the first is removed. -- This message was sent by Atlassian JIRA (v6.3.8#6338)