[jboss-remoting-issues] [JBoss JIRA] (JBREM-1334) Failure on connection not detected.

[Doug Grove (JIRA)]

     [ https://issues.jboss.org/browse/JBREM-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Grove updated JBREM-1334:
------------------------------
    Description: 
Looking at BisocketServerInvoker.run():

{code}
           if (!t.checkConnection())
            {
               t.shutdown();
               
               synchronized (this)
               {
                  if (!running)
                     return;
                  
                  controlConnectionThreadMap.remove(listenerId);
                  Object o = controlConnectionRestartsMap.get(listenerId);
                  int restarts = ((Integer)o).intValue();
                  
                  if (restarts + 1 > controlConnectionRestarts)
                  {
                     log.warn(this + ": detected failure on control connection " + t);
                     log.warn("Control connection " + listenerId + " has been recreated " + restarts + " times.");
                     log.warn("Assuming it is a connection to an old server, and will not restart");
                     controlConnectionRestartsMap.remove(listenerId);
                     continue;
                  }
                  
                  log.warn(this + ": detected failure on control connection " + t + 
                                  " (" + listenerId + 
                                  ": requesting new control connection");
               }
{code}

It looks like the check never succeeds and " detected failure on control connection " is logged indefinitely.

  was:
Lookin at BisocketServerInvoker.run():

{code}
           if (!t.checkConnection())
            {
               t.shutdown();
               
               synchronized (this)
               {
                  if (!running)
                     return;
                  
                  controlConnectionThreadMap.remove(listenerId);
                  Object o = controlConnectionRestartsMap.get(listenerId);
                  int restarts = ((Integer)o).intValue();
                  
                  if (restarts + 1 > controlConnectionRestarts)
                  {
                     log.warn(this + ": detected failure on control connection " + t);
                     log.warn("Control connection " + listenerId + " has been recreated " + restarts + " times.");
                     log.warn("Assuming it is a connection to an old server, and will not restart");
                     controlConnectionRestartsMap.remove(listenerId);
                     continue;
                  }
                  
                  log.warn(this + ": detected failure on control connection " + t + 
                                  " (" + listenerId + 
                                  ": requesting new control connection");
               }
{code}

It looks like the check never succeeds and " detected failure on control connection " is logged indefinitely.



> Failure on connection not detected.
> -----------------------------------
>
>                 Key: JBREM-1334
>                 URL: https://issues.jboss.org/browse/JBREM-1334
>             Project: JBoss Remoting
>          Issue Type: Bug
>    Affects Versions: 2.5.4.SP4
>         Environment: Red Hat JBoss EAP 5.1.2
>            Reporter: Doug Grove
>
> Looking at BisocketServerInvoker.run():
> {code}
>            if (!t.checkConnection())
>             {
>                t.shutdown();
>                
>                synchronized (this)
>                {
>                   if (!running)
>                      return;
>                   
>                   controlConnectionThreadMap.remove(listenerId);
>                   Object o = controlConnectionRestartsMap.get(listenerId);
>                   int restarts = ((Integer)o).intValue();
>                   
>                   if (restarts + 1 > controlConnectionRestarts)
>                   {
>                      log.warn(this + ": detected failure on control connection " + t);
>                      log.warn("Control connection " + listenerId + " has been recreated " + restarts + " times.");
>                      log.warn("Assuming it is a connection to an old server, and will not restart");
>                      controlConnectionRestartsMap.remove(listenerId);
>                      continue;
>                   }
>                   
>                   log.warn(this + ": detected failure on control connection " + t + 
>                                   " (" + listenerId + 
>                                   ": requesting new control connection");
>                }
> {code}
> It looks like the check never succeeds and " detected failure on control connection " is logged indefinitely.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)