[jboss-svn-commits] JBL Code SVN: r11003 - in labs/jbossrules/trunk/drools-compiler/src: test/java/org/drools/compiler and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: michael.neale at jboss.com
Date: 2007-04-16 09:31:48 -0400 (Mon, 16 Apr 2007)
New Revision: 11003

Modified:
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilder.java
   labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/compiler/PackageBuilderTest.java
Log:
JBRULES-799 Package name validation fixes

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilder.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilder.java	2007-04-16 13:09:05 UTC (rev 11002)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilder.java	2007-04-16 13:31:48 UTC (rev 11003)
@@ -379,6 +379,18 @@
         }
         return buf.toString();
     }
+    
+    
+    /**
+     * Reset the error list.
+     * This is useful when incrementally building packages.
+     * Care should be used when building this, if you 
+     * clear this when there were errors on items that a rule depends on
+     * (eg functions), then you will get spurious errors which will not be that helpful.
+     */
+    void resetErrors() {
+        this.results.clear();
+    }
 
     public static class MissingPackageNameException extends IllegalArgumentException {
         private static final long serialVersionUID = 320L;

Modified: labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/compiler/PackageBuilderTest.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/compiler/PackageBuilderTest.java	2007-04-16 13:09:05 UTC (rev 11002)
+++ labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/compiler/PackageBuilderTest.java	2007-04-16 13:31:48 UTC (rev 11003)
@@ -288,8 +288,23 @@
         
         builder.addPackageFromDrl( new StringReader("package foo") );
         builder.addPackageFromDrl( new StringReader("rule x end") );
-
+        
+        
+        
     }
+    
+    public void testErrorReset() throws Exception {
+        final PackageBuilder builder = new PackageBuilder();
+        
+        builder.addPackageFromDrl( new StringReader("package foo \n rule ORB") );
+        assertTrue(builder.hasErrors());
+        
+        builder.resetErrors();
+        assertFalse(builder.hasErrors());
+        
+        builder.addPackageFromDrl( new StringReader("package foo \n rule ORB") );
+        assertTrue(builder.hasErrors());
+    }
 
     public void testFactTemplate() {
         final PackageBuilder builder = new PackageBuilder();