[jboss-svn-commits] JBL Code SVN: r14109 - in labs/jbossrules/trunk/drools-jsr94/src: test/java/org/drools/decisiontable and 1 other directories.

[jboss-svn-commits at lists.jboss.org]

Author: mark.proctor at jboss.com
Date: 2007-08-08 23:02:25 -0400 (Wed, 08 Aug 2007)
New Revision: 14109

Modified:
   labs/jbossrules/trunk/drools-jsr94/src/main/java/org/drools/jsr94/rules/Constants.java
   labs/jbossrules/trunk/drools-jsr94/src/test/java/org/drools/decisiontable/SpreadsheetIntegrationTest.java
   labs/jbossrules/trunk/drools-jsr94/src/test/java/org/drools/jsr94/rules/RuleRuntimeTest.java
Log:
JBRULES-1061 jsr94 constants wrong package builder config constant, same name as rulebase config constant

Modified: labs/jbossrules/trunk/drools-jsr94/src/main/java/org/drools/jsr94/rules/Constants.java
===================================================================
--- labs/jbossrules/trunk/drools-jsr94/src/main/java/org/drools/jsr94/rules/Constants.java	2007-08-09 01:52:29 UTC (rev 14108)
+++ labs/jbossrules/trunk/drools-jsr94/src/main/java/org/drools/jsr94/rules/Constants.java	2007-08-09 03:02:25 UTC (rev 14109)
@@ -50,5 +50,5 @@
     public static final String RES_RULEBASE_CONFIG = "javax.rules.admin.RuleExecutionSet.ruleBaseConfiguration";
     
     /** <code>RuleExecutionSet</code> package builder config constant. */
-    public static final String RES_PACKAGEBUILDER_CONFIG = "javax.rules.admin.RuleExecutionSet.ruleBaseConfiguration";    
+    public static final String RES_PACKAGEBUILDER_CONFIG = "javax.rules.admin.RuleExecutionSet.packageBuilderConfiguration";    
 }

Modified: labs/jbossrules/trunk/drools-jsr94/src/test/java/org/drools/decisiontable/SpreadsheetIntegrationTest.java
===================================================================
--- labs/jbossrules/trunk/drools-jsr94/src/test/java/org/drools/decisiontable/SpreadsheetIntegrationTest.java	2007-08-09 01:52:29 UTC (rev 14108)
+++ labs/jbossrules/trunk/drools-jsr94/src/test/java/org/drools/decisiontable/SpreadsheetIntegrationTest.java	2007-08-09 03:02:25 UTC (rev 14109)
@@ -76,7 +76,6 @@
         session.executeRules();
         assertEquals( 1,
                       list.size() );
-
     }
 
 }
\ No newline at end of file

Modified: labs/jbossrules/trunk/drools-jsr94/src/test/java/org/drools/jsr94/rules/RuleRuntimeTest.java
===================================================================
--- labs/jbossrules/trunk/drools-jsr94/src/test/java/org/drools/jsr94/rules/RuleRuntimeTest.java	2007-08-09 01:52:29 UTC (rev 14108)
+++ labs/jbossrules/trunk/drools-jsr94/src/test/java/org/drools/jsr94/rules/RuleRuntimeTest.java	2007-08-09 03:02:25 UTC (rev 14109)
@@ -43,16 +43,26 @@
 
 import java.io.InputStreamReader;
 import java.io.Reader;
+import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 
 import javax.rules.RuleExecutionSetNotFoundException;
 import javax.rules.RuleRuntime;
+import javax.rules.RuleServiceProvider;
+import javax.rules.RuleServiceProviderManager;
 import javax.rules.StatefulRuleSession;
 import javax.rules.StatelessRuleSession;
 import javax.rules.admin.LocalRuleExecutionSetProvider;
 import javax.rules.admin.RuleAdministrator;
 import javax.rules.admin.RuleExecutionSet;
 
+import org.drools.RuleBaseConfiguration;
+import org.drools.decisiontable.Cheese;
+import org.drools.decisiontable.Person;
+import org.drools.decisiontable.SpreadsheetIntegrationTest;
+
 /**
  * Test the RuleRuntime implementation.
  *
@@ -171,4 +181,29 @@
         this.ruleAdministrator.deregisterRuleExecutionSet( this.RULES_RESOURCE,
                                                            null );
     }
+
+    public void testRuleBaseConfigurationConstant() throws Exception {
+        // JBRULES-1061
+        
+        Map properties = new HashMap();
+        properties.put( Constants.RES_SOURCE,
+                        Constants.RES_SOURCE_TYPE_DECISION_TABLE );
+
+        properties.put( Constants.RES_RULEBASE_CONFIG,
+                        new RuleBaseConfiguration() );
+
+        RuleServiceProviderManager.registerRuleServiceProvider( ExampleRuleEngineFacade.RULE_SERVICE_PROVIDER,
+                                                                RuleServiceProviderImpl.class );
+
+        RuleServiceProvider ruleServiceProvider = RuleServiceProviderManager.getRuleServiceProvider( ExampleRuleEngineFacade.RULE_SERVICE_PROVIDER );
+        RuleAdministrator ruleAdministrator = ruleServiceProvider.getRuleAdministrator();
+        LocalRuleExecutionSetProvider ruleSetProvider = ruleAdministrator.getLocalRuleExecutionSetProvider( null );
+
+        try {
+            RuleExecutionSet ruleExecutionSet = ruleSetProvider.createRuleExecutionSet( SpreadsheetIntegrationTest.class.getResourceAsStream( "IntegrationExampleTest.xls" ),
+                                                                                        properties );
+        } catch (Exception e) {
+            // fail should not throw an Excetpion
+        }
+    }
 }