[jboss-svn-commits] JBL Code SVN: r14229 - labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/editors/completion.

[jboss-svn-commits at lists.jboss.org]

Author: pombredanne
Date: 2007-08-14 20:49:32 -0400 (Tue, 14 Aug 2007)
New Revision: 14229

Modified:
   labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/editors/completion/DefaultCompletionProcessor.java
Log:
JBRULES-1080: strengthened possible corner cases and eliminated potential IOOBE in processing prefixes for completions

Modified: labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/editors/completion/DefaultCompletionProcessor.java
===================================================================
--- labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/editors/completion/DefaultCompletionProcessor.java	2007-08-15 00:46:55 UTC (rev 14228)
+++ labs/jbossrules/trunk/drools-eclipse/drools-eclipse-plugin/src/main/java/org/drools/eclipse/editors/completion/DefaultCompletionProcessor.java	2007-08-15 00:49:32 UTC (rev 14229)
@@ -292,7 +292,12 @@
                                                   Map params,
                                                   Collection results) {
 
-		String javaTextWithoutPrefix = javaText.substring(0, javaText.length() - prefix.length());
+		int endIndex = javaText.length() - prefix.length();
+        String javaTextWithoutPrefix = javaText;
+        //javaText can be an empty string.
+        if ( endIndex > 0 ) {
+            javaTextWithoutPrefix = javaText.substring(0, endIndex);
+        }
 		// boolean to filter default Object methods produced by code completion when in the beginning of a statement
 		boolean filterObjectMethods = false;
 		if ("".equals(javaTextWithoutPrefix.trim()) || START_OF_NEW_JAVA_STATEMENT.matcher(javaTextWithoutPrefix).matches()) {