[jboss-svn-commits] JBL Code SVN: r14280 - labs/jbossesb/trunk/product/rosetta/src/org/jboss/soa/esb/listeners/message.

[jboss-svn-commits at lists.jboss.org]

Author: tcunning
Date: 2007-08-15 21:42:48 -0400 (Wed, 15 Aug 2007)
New Revision: 14280

Modified:
   labs/jbossesb/trunk/product/rosetta/src/org/jboss/soa/esb/listeners/message/MessageCounter.java
   labs/jbossesb/trunk/product/rosetta/src/org/jboss/soa/esb/listeners/message/MessageCounterMBean.java
Log:
bug:JBESB-738
Change fields to end in "time" and "count" so we can identify them as "count"
and "time" metrics.


Modified: labs/jbossesb/trunk/product/rosetta/src/org/jboss/soa/esb/listeners/message/MessageCounter.java
===================================================================
--- labs/jbossesb/trunk/product/rosetta/src/org/jboss/soa/esb/listeners/message/MessageCounter.java	2007-08-16 01:42:11 UTC (rev 14279)
+++ labs/jbossesb/trunk/product/rosetta/src/org/jboss/soa/esb/listeners/message/MessageCounter.java	2007-08-16 01:42:48 UTC (rev 14280)
@@ -35,8 +35,8 @@
  */
 public class MessageCounter extends ServiceMBeanSupport implements MessageCounterMBean, Observer {
 
-	private String lastSuccessfulMessageTime;
-	private String lastFailedMessageTime;
+	private String lastSuccessfulMessageDate;
+	private String lastFailedMessageDate;
 	private int failedMessageCount;
 	private int successMessageCount;
 	private long totalProcessTime;
@@ -62,20 +62,16 @@
 	 * Get the time the last message was processed at.
 	 * @return time the last message was processed at
 	 */
-	public String getLastSuccessfulMessageTime() {
-		return lastSuccessfulMessageTime;
+	public String getLastSuccessfulMessageDate() {
+		return lastSuccessfulMessageDate;
 	}
 
 	/**
 	 * Get the time the last message was processed at.
 	 * @return time the last message was processed at
 	 */
-	public String getLastFailedMessageTime() {
-		if (lastFailedMessageTime != null) {
-			return lastFailedMessageTime;
-		} else {
-			return "No messages failed";
-		}
+	public String getLastFailedMessageDate() {
+		return lastFailedMessageDate;
 	}
 	
 	/**
@@ -106,11 +102,11 @@
 		if (msb.getMessageStatus().equals(MessageStatusBean.MESSAGE_SENT)) {
 			successMessageCount++;
 			Timestamp ts = new Timestamp(msb.getMessageTime());
-			lastSuccessfulMessageTime = ts.toString();
+			lastSuccessfulMessageDate = ts.toString();
 		} else if (msb.getMessageStatus().equals(MessageStatusBean.MESSAGE_FAILED)) {
 			failedMessageCount++;
 			Timestamp ts = new Timestamp(msb.getMessageTime());
-			lastFailedMessageTime = ts.toString();
+			lastFailedMessageDate = ts.toString();
 		}
 		
 		totalProcessTime += msb.getProcessTime();
@@ -150,8 +146,8 @@
 	 * Reset the counts - this resets the totals and the last message time. 
 	 */
 	public void resetCounts() {
-		lastSuccessfulMessageTime = null;
-		lastFailedMessageTime = null;
+		lastSuccessfulMessageDate = "---";
+		lastFailedMessageDate = "---";
 		successMessageCount = 0;
 		failedMessageCount = 0;
 		totalProcessTime = 0;

Modified: labs/jbossesb/trunk/product/rosetta/src/org/jboss/soa/esb/listeners/message/MessageCounterMBean.java
===================================================================
--- labs/jbossesb/trunk/product/rosetta/src/org/jboss/soa/esb/listeners/message/MessageCounterMBean.java	2007-08-16 01:42:11 UTC (rev 14279)
+++ labs/jbossesb/trunk/product/rosetta/src/org/jboss/soa/esb/listeners/message/MessageCounterMBean.java	2007-08-16 01:42:48 UTC (rev 14280)
@@ -23,7 +23,7 @@
 
 /**
  * MBean to represent simple message counting.    Stores the number of succesful and
- * failed messages, the last message time, total bytes and time, and has the ability
+ * failed messages, the last message time, total bytes and time, and has the ability 
  * to reset all counts.    
  * 
  * @author <a href="mailto:tcunning at redhat.com">tcunning at redhat.com</a> 
@@ -36,9 +36,9 @@
 	
 	public int getFailedMessageCount();
 	
-	public String getLastSuccessfulMessageTime();
+	public String getLastSuccessfulMessageDate();
 
-	public String getLastFailedMessageTime();
+	public String getLastFailedMessageDate();
 	
 	public Double getAverageSuccessTime();