[jboss-svn-commits] JBL Code SVN: r17418 - in labs/jbossrules/trunk/drools-analytics/src: test/java/org/drools/analytics and 1 other directories.
jboss-svn-commits at lists.jboss.org
jboss-svn-commits at lists.jboss.org
Thu Dec 27 15:38:09 EST 2007
Author: Rikkola
Date: 2007-12-27 15:38:09 -0500 (Thu, 27 Dec 2007)
New Revision: 17418
Removed:
labs/jbossrules/trunk/drools-analytics/src/main/resources/StaticQualityAnalysis.drl
Modified:
labs/jbossrules/trunk/drools-analytics/src/test/java/org/drools/analytics/AnalyzerTest.java
labs/jbossrules/trunk/drools-analytics/src/test/resources/org/drools/analytics/Misc3.drl
Log:
Fix for broken test.
Deleted: labs/jbossrules/trunk/drools-analytics/src/main/resources/StaticQualityAnalysis.drl
===================================================================
--- labs/jbossrules/trunk/drools-analytics/src/main/resources/StaticQualityAnalysis.drl 2007-12-27 19:57:35 UTC (rev 17417)
+++ labs/jbossrules/trunk/drools-analytics/src/main/resources/StaticQualityAnalysis.drl 2007-12-27 20:38:09 UTC (rev 17418)
@@ -1,134 +0,0 @@
- package drools.analytics
-
-import org.drools.analytics.*
-
-global AnalysisResult result
-
-#
-#
-#
-#
-# This file is here as TODO list. It does not work with the current analytics components.
-# - Toni Rikkola -
-#
-#
-#
-#
-#
-
-rule "Less than"
- when
- constraint: Constraint( f:field, o:operator == "<", v:value, r:ruleName, ot:objectType )
- not Constraint( field == f, objectType == ot, ruleName != r, value == v,
- other:operator -> (other.equals(">=") || other.equals("==") ))
- then
- result.addWarning(drools, "You may be missing a greater or equal range of values: " + constraint);
-end
-
-rule "Less than or equal to"
- when
- constraint: Constraint( f:field, o:operator == "<=", v:value, r:ruleName, ot:objectType )
- not Constraint( field == f, objectType == ot, ruleName != r, operator == ">", value == v )
- then
- result.addWarning(drools, "You may be missing a greater range of values for: " + constraint);
-end
-
-rule "Greater than"
- when
- constraint: Constraint( f:field, o:operator == ">", v:value, r:ruleName, ot:objectType )
- not Constraint( field == f, objectType == ot, ruleName != r, value == v,
- other:operator -> (other.equals("<=") || other.equals("==") ))
- then
- result.addWarning(drools, "You may be missing a lesser or equal range of values for: " + constraint);
-end
-
-
-rule "Greater than or equal to"
- when
- constraint: Constraint( f:field, o:operator == ">=", v:value, r:ruleName, ot:objectType )
- not Constraint( field == f, objectType == ot, ruleName != r, operator == "<", value == v )
- then
- result.addWarning(drools, "You may be missing a lesser range of values for: " + constraint);
-end
-
-rule "Inequal - missing equality case"
- when
- constraint: Constraint( f:field, o:operator == "!=", v:value, r:ruleName, ot:objectType )
- not Constraint( field == f, objectType == ot, value == v,
- other: operator -> (other.equals("==") || other.equals("|=")) )
- then
- result.addWarning(drools, "You specified an inequality, but there is no equivalent equality: " + constraint);
-end
-
-rule "same field with conflicting constraints on the one Rule - impossible to satisfy"
- when
- then
-end
-
-rule "Not node conflicting with top level CE - impossible to satisfy"
- when
-
- then
-
-end
-
-rule "Subsumption"
- when
- //need to check RHS for rule, to have the same action
- //and when there is at least one Pattern in common
- then
-
-end
-
-rule "Combination explosion risk"
- when
-
- then
-
-end
-
-rule "Major combination explosion danger"
- when
-
- then
-
-end
-
-rule "Infinite loop risk warning"
- when
- //RHS modifies a fact which LHS depends on, no "no loop"
- then
-
-end
-
-rule "No action - possibly commented out"
- when
- r: Rule(rhs == "")
- then
- result.addWarning(drools, "This rule has no action: " + r.getName());
-end
-
-rule "Less restrictive constraint first"
- when
- //if the first constraint is less restrictive then the next, suggest re-arrange
- //works off the pattern
- then
-
-end
-
-rule "Excessive use of salience"
- when
- not Rule(salienceValue == 0)
- then
- result.addWarning(drools, "Salience is being used heavily, if possible, consider using agenda groups to break up the rule package.");
-end
-
-
-
-
-rule "Only a few values of salience - consider using agenda-groups"
- when
- //when agenda groups would be better for controlling the flow in phases then salience.
- then
-
-end
Modified: labs/jbossrules/trunk/drools-analytics/src/test/java/org/drools/analytics/AnalyzerTest.java
===================================================================
--- labs/jbossrules/trunk/drools-analytics/src/test/java/org/drools/analytics/AnalyzerTest.java 2007-12-27 19:57:35 UTC (rev 17417)
+++ labs/jbossrules/trunk/drools-analytics/src/test/java/org/drools/analytics/AnalyzerTest.java 2007-12-27 20:38:09 UTC (rev 17418)
@@ -12,7 +12,7 @@
public class AnalyzerTest extends TestCase {
- public void fixmetestAnalyzer() throws Exception {
+ public void testAnalyzer() throws Exception {
Analyzer anal = new Analyzer();
DrlParser p = new DrlParser();
@@ -26,7 +26,7 @@
AnalyticsResult result = anal.getResult();
assertNotNull(result);
assertEquals(0, result.getBySeverity(AnalyticsMessageBase.Severity.ERROR).size());
- assertEquals(17, result.getBySeverity(AnalyticsMessageBase.Severity.WARNING).size());
+ assertEquals(10, result.getBySeverity(AnalyticsMessageBase.Severity.WARNING).size());
assertEquals(1, result.getBySeverity(AnalyticsMessageBase.Severity.NOTE).size());
@@ -44,8 +44,7 @@
result = anal.getResult();
assertNotNull(result);
assertEquals(0, result.getBySeverity(AnalyticsMessageBase.Severity.ERROR).size());
- // This row has a problem
- assertEquals( 17, result.getBySeverity(AnalyticsMessageBase.Severity.WARNING).size());
+ assertEquals(10, result.getBySeverity(AnalyticsMessageBase.Severity.WARNING).size());
assertEquals(1, result.getBySeverity(AnalyticsMessageBase.Severity.NOTE).size());
Modified: labs/jbossrules/trunk/drools-analytics/src/test/resources/org/drools/analytics/Misc3.drl
===================================================================
--- labs/jbossrules/trunk/drools-analytics/src/test/resources/org/drools/analytics/Misc3.drl 2007-12-27 19:57:35 UTC (rev 17417)
+++ labs/jbossrules/trunk/drools-analytics/src/test/resources/org/drools/analytics/Misc3.drl 2007-12-27 20:38:09 UTC (rev 17418)
@@ -2,7 +2,7 @@
import com.sample.DroolsTest.Message;
-
+/*
rule "Redundant restrictions"
when
RedundancyPattern( a == 1, a == 1 )
@@ -17,17 +17,19 @@
then
System.out.println("TEST");
end
-
+*/
rule "Redundant rule 2, rules"
when
RedundancyPattern( a == 1 )
- RedundancyPattern2( a == 1 )
+ RedundancyPattern2( a >= 1 )
+ RedundancyPattern3( a == 1, a == 1 )
then
System.out.println("TEST");
end
rule "Equivalent rule"
when
+ BlaaBlaa( a == 1 )
RedundancyPattern( a == 1 )
RedundancyPattern2( a == 1 )
then
More information about the jboss-svn-commits
mailing list