[jboss-svn-commits] JBL Code SVN: r21116 - in labs/jbossesb/workspace/dbevenius/security/product/rosetta: tests/src/org/jboss/soa/esb/services/security and 1 other directory.

jboss-svn-commits at lists.jboss.org jboss-svn-commits at lists.jboss.org
Fri Jul 18 10:08:43 EDT 2008


Author: beve
Date: 2008-07-18 10:08:42 -0400 (Fri, 18 Jul 2008)
New Revision: 21116

Modified:
   labs/jbossesb/workspace/dbevenius/security/product/rosetta/src/org/jboss/soa/esb/services/security/SecurityService.java
   labs/jbossesb/workspace/dbevenius/security/product/rosetta/src/org/jboss/soa/esb/services/security/SecurityServiceImpl.java
   labs/jbossesb/workspace/dbevenius/security/product/rosetta/tests/src/org/jboss/soa/esb/services/security/SecurityServiceImplUnitTest.java
Log:
Cleaning up the api a little.


Modified: labs/jbossesb/workspace/dbevenius/security/product/rosetta/src/org/jboss/soa/esb/services/security/SecurityService.java
===================================================================
--- labs/jbossesb/workspace/dbevenius/security/product/rosetta/src/org/jboss/soa/esb/services/security/SecurityService.java	2008-07-18 14:04:06 UTC (rev 21115)
+++ labs/jbossesb/workspace/dbevenius/security/product/rosetta/src/org/jboss/soa/esb/services/security/SecurityService.java	2008-07-18 14:08:42 UTC (rev 21116)
@@ -21,9 +21,7 @@
 package org.jboss.soa.esb.services.security;
 
 import java.net.URL;
-import java.security.PrivilegedAction;
 
-import javax.security.auth.Subject;
 import javax.security.auth.login.LoginException;
 
 import org.jboss.soa.esb.ConfigurationException;
@@ -37,7 +35,5 @@
 {
 	void addPolicy(final URL policyUrl) throws ConfigurationException;
 
-	<T> T runAsSubject(Subject subject, PrivilegedAction<T> action);
-
 	void authenticate(final JaasSecurityContext securityContext) throws LoginException;
 }

Modified: labs/jbossesb/workspace/dbevenius/security/product/rosetta/src/org/jboss/soa/esb/services/security/SecurityServiceImpl.java
===================================================================
--- labs/jbossesb/workspace/dbevenius/security/product/rosetta/src/org/jboss/soa/esb/services/security/SecurityServiceImpl.java	2008-07-18 14:04:06 UTC (rev 21115)
+++ labs/jbossesb/workspace/dbevenius/security/product/rosetta/src/org/jboss/soa/esb/services/security/SecurityServiceImpl.java	2008-07-18 14:08:42 UTC (rev 21116)
@@ -44,15 +44,6 @@
 	
 	private Logger log = Logger.getLogger(SecurityServiceImpl.class);
 	
-	/**
-	 * Will run the priviledged action with a fresh ActionControlContext
-	 */
-	@SuppressWarnings("unchecked")
-	public <T> T runAsSubject( final Subject subject, final PrivilegedAction<T> action )
-	{
-		return (T) Subject.doAsPrivileged( subject , action, null);
-	}
-	
 	public void authenticate( final JaasSecurityContext context) throws LoginException
 	{
 		log.info( context );

Modified: labs/jbossesb/workspace/dbevenius/security/product/rosetta/tests/src/org/jboss/soa/esb/services/security/SecurityServiceImplUnitTest.java
===================================================================
--- labs/jbossesb/workspace/dbevenius/security/product/rosetta/tests/src/org/jboss/soa/esb/services/security/SecurityServiceImplUnitTest.java	2008-07-18 14:04:06 UTC (rev 21115)
+++ labs/jbossesb/workspace/dbevenius/security/product/rosetta/tests/src/org/jboss/soa/esb/services/security/SecurityServiceImplUnitTest.java	2008-07-18 14:08:42 UTC (rev 21116)
@@ -22,8 +22,6 @@
 
 import static org.junit.Assert.assertEquals;
 
-import java.security.Principal;
-import java.security.PrivilegedAction;
 import java.util.Set;
 
 import javax.security.auth.Subject;
@@ -50,14 +48,6 @@
 	private static String policyFileName = "jaas-test.config";
 	
 	@Test
-	public void runAsSubject()
-	{
-		subject.getPrincipals().add( new MockPrincipal( "danbev") );
-		String name = service.runAsSubject( subject, new Action() );
-		assertEquals( "somestring", name );
-	}
-	
-	@Test
 	public void loginSuccess() throws LoginException, ConfigurationException
 	{
 		SecurityConfigInfo configInfo = SecurityConfigInfo.createSecurityInfo(policyFileName, null, null, "SuccessfulLogin");
@@ -89,34 +79,4 @@
 		return new JUnit4TestAdapter( SecurityServiceImplUnitTest.class );
 	}
 	
-	private class Action implements PrivilegedAction<String>
-	{
-		public String run()
-		{
-			return "somestring";
-		}
-	}
-	
-	private class MockPrincipal implements Principal
-	{
-		String name;
-		
-		public MockPrincipal(String name)
-		{
-			super();
-			this.name = name;
-		}
-
-		public MockPrincipal()
-		{
-			super();
-		}
-
-		public String getName()
-		{
-			return null;
-		}
-		
-	}
-
 }




More information about the jboss-svn-commits mailing list