[jboss-svn-commits] JBL Code SVN: r25369 - labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler.

[jboss-svn-commits at lists.jboss.org]

Author: mark.proctor at jboss.com
Date: 2009-02-20 14:24:04 -0500 (Fri, 20 Feb 2009)
New Revision: 25369

Modified:
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/ProcessBuilder.java
Log:
-do not process null process, as the xml parser failed and it'll give null pointers.

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/ProcessBuilder.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/ProcessBuilder.java	2009-02-20 17:40:23 UTC (rev 25368)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/ProcessBuilder.java	2009-02-20 19:24:04 UTC (rev 25369)
@@ -226,7 +226,13 @@
                 portedReader = reader;
             }
             Process process = xmlReader.read(portedReader);
-            buildProcess( process, resource );
+            if ( process != null ) {
+                // it is possible an xml file could not be parsed, so we need to stop null pointers
+                buildProcess( process, resource );
+            } else {
+                // @TODO could we maybe add something a bit more informative about what is wrong with the XML ?
+                this.errors.add( new RuleFlowLoadError( "unable to parse xml", null ) );
+            }
         } finally {
             Thread.currentThread().setContextClassLoader( oldLoader );
         }