[jboss-svn-commits] JBL Code SVN: r25389 - in labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command: impl and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: Rikkola
Date: 2009-02-23 10:37:36 -0500 (Mon, 23 Feb 2009)
New Revision: 25389

Removed:
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/AddEventListenerCommand.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/RemoveEventListenerCommand.java
Modified:
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/impl/CommandBasedStatefulKnowledgeSession.java
Log:
JBRULES-1915: Improve process persistence usability
-These commands can't work the way they were done

Deleted: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/AddEventListenerCommand.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/AddEventListenerCommand.java	2009-02-23 15:34:30 UTC (rev 25388)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/AddEventListenerCommand.java	2009-02-23 15:37:36 UTC (rev 25389)
@@ -1,49 +0,0 @@
-package org.drools.process.command;
-
-import org.drools.StatefulSession;
-import org.drools.event.process.ProcessEventListener;
-import org.drools.event.rule.AgendaEventListener;
-import org.drools.event.rule.WorkingMemoryEventListener;
-import org.drools.impl.StatefulKnowledgeSessionImpl;
-
-public class AddEventListenerCommand
-    implements
-    Command<Object> {
-
-    private WorkingMemoryEventListener workingMemoryEventlistener = null;
-    private AgendaEventListener        agendaEventlistener        = null;
-    private ProcessEventListener       processEventlistener       = null;
-
-    public AddEventListenerCommand(WorkingMemoryEventListener listener) {
-        this.workingMemoryEventlistener = listener;
-    }
-
-    public AddEventListenerCommand(AgendaEventListener listener) {
-        this.agendaEventlistener = listener;
-    }
-
-    public AddEventListenerCommand(ProcessEventListener listener) {
-        this.processEventlistener = listener;
-    }
-
-    public Object execute(StatefulSession session) {
-        if ( workingMemoryEventlistener != null ) {
-            session.addEventListener( new StatefulKnowledgeSessionImpl.WorkingMemoryEventListenerWrapper( workingMemoryEventlistener ) );
-        } else if ( agendaEventlistener != null ) {
-            session.addEventListener( new StatefulKnowledgeSessionImpl.AgendaEventListenerWrapper( agendaEventlistener ) );
-        } else {
-            session.addEventListener( new StatefulKnowledgeSessionImpl.ProcessEventListenerWrapper( processEventlistener ) );
-        }
-        return null;
-    }
-
-    public String toString() {
-        if ( workingMemoryEventlistener != null ) {
-            return "session.addEventListener( " + workingMemoryEventlistener + " );";
-        } else if ( agendaEventlistener != null ) {
-            return "session.addEventListener( " + agendaEventlistener + " );";
-        } else {
-            return "session.addEventListener( " + processEventlistener + " );";
-        }
-    }
-}

Deleted: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/RemoveEventListenerCommand.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/RemoveEventListenerCommand.java	2009-02-23 15:34:30 UTC (rev 25388)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/RemoveEventListenerCommand.java	2009-02-23 15:37:36 UTC (rev 25389)
@@ -1,49 +0,0 @@
-package org.drools.process.command;
-
-import org.drools.StatefulSession;
-import org.drools.event.process.ProcessEventListener;
-import org.drools.event.rule.AgendaEventListener;
-import org.drools.event.rule.WorkingMemoryEventListener;
-import org.drools.impl.StatefulKnowledgeSessionImpl;
-
-public class RemoveEventListenerCommand
-    implements
-    Command<Object> {
-
-    private WorkingMemoryEventListener workingMemoryEventListener = null;
-    private AgendaEventListener        agendaEventListener        = null;
-    private ProcessEventListener       processEventListener       = null;
-
-    public RemoveEventListenerCommand(WorkingMemoryEventListener listener) {
-        this.workingMemoryEventListener = listener;
-    }
-
-    public RemoveEventListenerCommand(AgendaEventListener listener) {
-        this.agendaEventListener = listener;
-    }
-
-    public RemoveEventListenerCommand(ProcessEventListener listener) {
-        this.processEventListener = listener;
-    }
-
-    public Object execute(StatefulSession session) {
-        if ( workingMemoryEventListener != null ) {
-            session.removeEventListener( new StatefulKnowledgeSessionImpl.WorkingMemoryEventListenerWrapper( workingMemoryEventListener ) );
-        } else if ( agendaEventListener != null ) {
-            session.removeEventListener( new StatefulKnowledgeSessionImpl.AgendaEventListenerWrapper( agendaEventListener ) );
-        } else {
-            session.removeEventListener( new StatefulKnowledgeSessionImpl.ProcessEventListenerWrapper( processEventListener ) );
-        }
-        return null;
-    }
-
-    public String toString() {
-        if ( workingMemoryEventListener != null ) {
-            return "session.removeEventListener( " + workingMemoryEventListener + " );";
-        } else if ( agendaEventListener != null ) {
-            return "session.removeEventListener( " + agendaEventListener + " );";
-        } else {
-            return "session.removeEventListener( " + processEventListener + " );";
-        }
-    }
-}

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/impl/CommandBasedStatefulKnowledgeSession.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/impl/CommandBasedStatefulKnowledgeSession.java	2009-02-23 15:34:30 UTC (rev 25388)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/command/impl/CommandBasedStatefulKnowledgeSession.java	2009-02-23 15:37:36 UTC (rev 25389)
@@ -10,7 +10,6 @@
 import org.drools.event.rule.AgendaEventListener;
 import org.drools.event.rule.WorkingMemoryEventListener;
 import org.drools.process.command.AbortWorkItemCommand;
-import org.drools.process.command.AddEventListenerCommand;
 import org.drools.process.command.CommandService;
 import org.drools.process.command.CompleteWorkItemCommand;
 import org.drools.process.command.FireAllRulesCommand;
@@ -30,7 +29,6 @@
 import org.drools.process.command.HaltCommand;
 import org.drools.process.command.InsertObjectCommand;
 import org.drools.process.command.RegisterWorkItemHandlerCommand;
-import org.drools.process.command.RemoveEventListenerCommand;
 import org.drools.process.command.RetractCommand;
 import org.drools.process.command.SetGlobalCommand;
 import org.drools.process.command.SignalEventCommand;
@@ -230,11 +228,11 @@
     }
 
     public void addEventListener(WorkingMemoryEventListener listener) {
-        commandService.execute( new AddEventListenerCommand( listener ) );
+        throw new UnsupportedOperationException();
     }
 
     public void addEventListener(AgendaEventListener listener) {
-        commandService.execute( new AddEventListenerCommand( listener ) );
+        throw new UnsupportedOperationException();
     }
 
     public Collection<AgendaEventListener> getAgendaEventListeners() {
@@ -246,15 +244,15 @@
     }
 
     public void removeEventListener(WorkingMemoryEventListener listener) {
-        commandService.execute( new RemoveEventListenerCommand( listener ) );
+        throw new UnsupportedOperationException();
     }
 
     public void removeEventListener(AgendaEventListener listener) {
-        commandService.execute( new RemoveEventListenerCommand( listener ) );
+        throw new UnsupportedOperationException();
     }
 
     public void addEventListener(ProcessEventListener listener) {
-        commandService.execute( new AddEventListenerCommand( listener ) );
+        throw new UnsupportedOperationException();
     }
 
     public Collection<ProcessEventListener> getProcessEventListeners() {
@@ -262,7 +260,7 @@
     }
 
     public void removeEventListener(ProcessEventListener listener) {
-        commandService.execute( new RemoveEventListenerCommand( listener ) );
+        throw new UnsupportedOperationException();
     }
 
     public Object getGlobal(String identifier) {