[jboss-svn-commits] JBoss Common SVN: r3296 - jboss-logmanager/trunk/src/main/java/org/jboss/logmanager.

[jboss-svn-commits at lists.jboss.org]

Author: david.lloyd at jboss.com
Date: 2009-06-19 21:08:34 -0400 (Fri, 19 Jun 2009)
New Revision: 3296

Modified:
   jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/LoggerNode.java
Log:
More useless sync

Modified: jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/LoggerNode.java
===================================================================
--- jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/LoggerNode.java	2009-06-20 00:54:27 UTC (rev 3295)
+++ jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/LoggerNode.java	2009-06-20 01:08:34 UTC (rev 3296)
@@ -91,7 +91,6 @@
         } else {
             fullName = parent.fullName + "." + nodeName;
         }
-        parent.children.put(nodeName, this);
         this.context = context;
     }
 
@@ -197,13 +196,11 @@
     Logger getParentLogger() {
         LoggerNode node = parent;
         while (node != null) {
-            synchronized(node) {
-                final Logger instance = node.getLogger();
-                if (instance != null) {
-                    return instance;
-                }
-                node = node.parent;
+            final Logger instance = node.getLogger();
+            if (instance != null) {
+                return instance;
             }
+            node = node.parent;
         }
         return null;
     }
@@ -219,7 +216,7 @@
 
     /**
      * Recursively update the effective log level of all log instances on all children.  The recursion depth will be proportionate to the
-     * log node nesting depth so stack use should not be an issue.  Must only be called while the logmanager's level
+     * log node nesting depth so stack use should not be an issue.  Must only be called while the log context's level
      * change lock is held.
      *
      * @param newLevel the new effective level
@@ -227,11 +224,9 @@
     void updateChildEffectiveLevel(int newLevel) {
         for (LoggerNode node : children.values()) {
             if (node != null) {
-                synchronized (node) {
-                    final Logger instance = node.getLogger();
-                    if (instance != null) {
-                        instance.setEffectiveLevel(newLevel);
-                    }
+                final Logger instance = node.getLogger();
+                if (instance != null) {
+                    instance.setEffectiveLevel(newLevel);
                 }
             }
         }