[jboss-svn-commits] JBL Code SVN: r35493 - labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/decisiontable.

[jboss-svn-commits at lists.jboss.org]

Author: ge0ffrey
Date: 2010-10-12 06:39:21 -0400 (Tue, 12 Oct 2010)
New Revision: 35493

Modified:
   labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/decisiontable/GuidedDecisionTableWidget.java
Log:
refactor refreshGrid() method: Do not use widget counts magic numbers and no unneeded VerticalPanel wrappings.

Modified: labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/decisiontable/GuidedDecisionTableWidget.java
===================================================================
--- labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/decisiontable/GuidedDecisionTableWidget.java	2010-10-12 10:18:56 UTC (rev 35492)
+++ labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/decisiontable/GuidedDecisionTableWidget.java	2010-10-12 10:39:21 UTC (rev 35493)
@@ -112,6 +112,7 @@
 
     private GuidedDecisionTable         dt;
     private VerticalPanel               layout;
+    private PrettyFormLayout            configureColumnsNote;
     private GridPanel                   grid;
     private FieldDef[]                  fds;
     private VerticalPanel               attributeConfigWidget;
@@ -168,6 +169,14 @@
         buttonPanel.add( getToolbarMenuButton() );
         layout.add( buttonPanel );
 
+        configureColumnsNote = new PrettyFormLayout();
+        configureColumnsNote.startSection();
+        configureColumnsNote.addRow(
+                new HTML( "<img src='images/information.gif'/>&nbsp;" + constants.ConfigureColumnsNote()) );
+        configureColumnsNote.endSection();
+        configureColumnsNote.setVisible( false );
+        layout.add( configureColumnsNote );
+
         refreshGrid();
 
         initWidget( layout );
@@ -729,26 +738,13 @@
     }
 
     private void refreshGrid() {
-        if ( layout.getWidgetCount() > 2 ) {
-            layout.remove( 2 );
-        }
-        if ( dt.actionCols.size() == 0 && dt.conditionCols.size() == 0 && dt.actionCols.size() == 0 ) {
-            VerticalPanel vp = new VerticalPanel();
-            vp.setWidth( "100%" );
-            PrettyFormLayout pfl = new PrettyFormLayout();
-            pfl.startSection();
-            pfl.addRow( new HTML( "<img src='images/information.gif'/>&nbsp;" + constants.ConfigureColumnsNote() ) );
+        configureColumnsNote.setVisible( dt.actionCols.size() == 0 && dt.conditionCols.size() == 0 && dt.actionCols.size() == 0 );
 
-            pfl.endSection();
-            vp.add( pfl );
-            grid = doGrid();
-            vp.add( grid );
-            layout.add( vp );
-
-        } else {
-            grid = doGrid();
-            layout.add( grid );
+        if ( layout.getWidgetIndex( grid ) >= 0 ) {
+            layout.remove( grid );
         }
+        grid = doGrid();
+        layout.add( grid );
     }
 
     private GridPanel doGrid() {