[jboss-svn-commits] JBL Code SVN: r35640 - labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer.

[jboss-svn-commits at lists.jboss.org]

Author: ge0ffrey
Date: 2010-10-21 08:31:58 -0400 (Thu, 21 Oct 2010)
New Revision: 35640

Modified:
   labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/PackagesTree.java
Log:
don't rely on the fact that (new String[5] instanceof Object[]) is true + refactor extract local variable

Modified: labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/PackagesTree.java
===================================================================
--- labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/PackagesTree.java	2010-10-21 12:16:32 UTC (rev 35639)
+++ labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/PackagesTree.java	2010-10-21 12:31:58 UTC (rev 35640)
@@ -184,8 +184,9 @@
 
         TabOpener opener = TabOpener.getInstance();
 
-        if ( node.getUserObject() instanceof PackageConfigData && !"global".equals( ((PackageConfigData) node.getUserObject()).name ) ) {
-            PackageConfigData pc = (PackageConfigData) node.getUserObject();
+        Object userObject = node.getUserObject();
+        if ( userObject instanceof PackageConfigData && !"global".equals( ((PackageConfigData) userObject).name ) ) {
+            PackageConfigData pc = (PackageConfigData) userObject;
             RulePackageSelector.currentlySelectedPackage = pc.name;
 
             String uuid = pc.uuid;
@@ -196,8 +197,8 @@
                                               refreshTree();
                                           }
                                       } );
-        } else if ( node.getUserObject() instanceof Object[] ) {
-            final String[] formats = (String[]) node.getUserObject();
+        } else if ( userObject instanceof String[] ) {
+            final String[] formats = (String[]) userObject;
             final PackageConfigData packageConfigData = (PackageConfigData) node.getParentItem().getUserObject();
             RulePackageSelector.currentlySelectedPackage = packageConfigData.name;
             String key = key( formats,