[jboss-svn-commits] JBL Code SVN: r35765 - in labs/jbosslabs/labs-3.0-build/integration/sbs/reports/trunk/src: test/java/org/jboss/community/sbs/plugin/reports/monthly/valuesource and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: velias
Date: 2010-10-27 09:06:19 -0400 (Wed, 27 Oct 2010)
New Revision: 35765

Modified:
   labs/jbosslabs/labs-3.0-build/integration/sbs/reports/trunk/src/main/java/org/jboss/community/sbs/plugin/reports/monthly/valuesource/FishEyeCallException.java
   labs/jbosslabs/labs-3.0-build/integration/sbs/reports/trunk/src/test/java/org/jboss/community/sbs/plugin/reports/monthly/valuesource/FISHEYEValueSourceTest.java
Log:
Improved exception handling on FISHEYE calls - messages in exception now contains FishEye key used on call

Modified: labs/jbosslabs/labs-3.0-build/integration/sbs/reports/trunk/src/main/java/org/jboss/community/sbs/plugin/reports/monthly/valuesource/FishEyeCallException.java
===================================================================
--- labs/jbosslabs/labs-3.0-build/integration/sbs/reports/trunk/src/main/java/org/jboss/community/sbs/plugin/reports/monthly/valuesource/FishEyeCallException.java	2010-10-27 13:01:24 UTC (rev 35764)
+++ labs/jbosslabs/labs-3.0-build/integration/sbs/reports/trunk/src/main/java/org/jboss/community/sbs/plugin/reports/monthly/valuesource/FishEyeCallException.java	2010-10-27 13:06:19 UTC (rev 35765)
@@ -60,7 +60,7 @@
     sb.append("FISHEYE HTTP call failed");
 
     if (feKey != null) {
-      sb.append(" for key ").append(feKey);
+      sb.append(" for key '").append(feKey).append("'");
     }
 
     String message = super.getMessage();

Modified: labs/jbosslabs/labs-3.0-build/integration/sbs/reports/trunk/src/test/java/org/jboss/community/sbs/plugin/reports/monthly/valuesource/FISHEYEValueSourceTest.java
===================================================================
--- labs/jbosslabs/labs-3.0-build/integration/sbs/reports/trunk/src/test/java/org/jboss/community/sbs/plugin/reports/monthly/valuesource/FISHEYEValueSourceTest.java	2010-10-27 13:01:24 UTC (rev 35764)
+++ labs/jbosslabs/labs-3.0-build/integration/sbs/reports/trunk/src/test/java/org/jboss/community/sbs/plugin/reports/monthly/valuesource/FISHEYEValueSourceTest.java	2010-10-27 13:06:19 UTC (rev 35765)
@@ -203,7 +203,7 @@
         val = tested.getValues(id);
         Assert.fail();
       } catch (FishEyeCallException e) {
-        // ok
+        Assert.assertEquals(id, e.getFeKey());
       } finally {
         server.disconnect();
       }
@@ -215,7 +215,7 @@
         val = tested.getValues(id);
         Assert.fail();
       } catch (FishEyeCallException e) {
-        // ok
+        Assert.assertEquals(id, e.getFeKey());
       } finally {
         server.disconnect();
       }