[jboss-user] [JBoss Seam] - Re: Mathematical captcha & Email obfuscator

[petemuir]

Sorry, I might have sounded a bit negative on the bug tracker - don't get me wrong - I and everyone else (being presumptuous) is really grateful for your contribution :)

"Homer J." wrote : 1. I purposefully didn't use the patch format because I thought it's easier for you to integrate this way and my code doesn't rely on existing seam code. Further my code is "fine grained" - like you demanded. So all you / the seam developers have to do is to rename the classes & merge faces-config.xml, jsf-ui.taglib.xml, taglib.tld into JBossSeam/src/ui.

I find it much easier to read a patch than a set of files - and it also means that you can submit a patch for each area of functionality (even if some patches depend upon others) - such we can see how you've built up the component.  It also means that we can more easily choose to apply part of your functionality and know that it works as you intended...

At the end of the day, Gavin will need to review all this anyway, and this will make it faster for him.

anonymous wrote : 2. I might be wrong but AFAIK MathCaptchaResponseValidator does the same job as org.jboss.seam.captcha.CaptchaResponseValidator - that means it gets called by the hibernate validator and relays validation to the MathCaptcha component.

Sorry, my bad, yes you are completely correct.

anonymous wrote : 3. please see 1.

Just far less source of errors - someone forgets to rename something somewhere and it all goes wrong :(  If you say - I've developed and tested this patch against Seam head and it works great - then we can apply it with much less work!

anonymous wrote : 4. This part I don't understand: "Further, we are currently trying to work out what the role of JSF components is in Seam. I think we need to hold on commiting the JSF components for now." My hopes just were that you include it in jboss-seam-ui.jar so it can be used like s:link, s:cache, ...

So, with the addition of the Ajax4jsf, RichFaces etc. projects to jboss.org, we are considering what role JSF components have in Seam, and whether some of the controls should be moved to other jboss.org projects.  We haven't finished discussing this yet afaik :) So I was just suggesting that we hold of committing this until we have a roadmap for JSF components in Seam.  We are still quite a way off 1.3.0.GA so this should be resolved by then!

anonymous wrote : However: My intention was to give you a working example as proof of concept but if you insist on using the patch format I can give it a try (I haven't used it before but I have trust in my eclipse so this will probably work ;)).

I always had problems with Eclipse and CVS patch on the anoncvs connection (it mangles whitespace and newines) and had much more success with command line cvs (looks like you are on a unix machine so this shouldn't be a problem :) ).

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4041625#4041625

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4041625