[jboss-user] [JBoss Tools (users)] - Re: WTP2.0.1, JBossAS-Tools-1.0.0.beta4 not publishing corre

dlmiles do-not-reply at jboss.com
Fri Oct 12 21:49:19 EDT 2007


"max.andersen at jboss.com" wrote : I stepped through the code of jstpublisher andi don't see any temp file copying being performed when we use our adapter...I do realize that tomcat and jboss adapter does this of different reasons (tomcat - has it as a "deploy" location and jboss wtp as a tmp storage before zipping it up)
  | 
  | I'm not saying we don't have issues across disk boundaries; i'm just saying i'm not seeing any temporary files being created...

My comment earlier was that I guess you delegate the task of the actual file copy to PublishUtil and as it stands this API provided by WTP is only good if you intend to use the ".../tmp1/" publishing area (due to this cross file system concern).  This is why I think you need to open an API change request with WTP (or at least have them knock you back and fork your own implementation of PublishUtil).  I can see any reason why you can't have the API improved as it should be possible to maintain 100% backward compatibility.

The copy of PublishUtil I have from 1.5 still has the bug that is uses a static variable for the file copy buffer and this class is shared by many drivers, and as far as I know having two runtimes active at the same time is allowed and updates maybe done concurrently.  So instancing this class with a private 'byte[] buffer' and a configurable 'File tempDir' makes sense to me.


Anyway to spot the temp file usage try something like this:

Set a breakpoint in this class org.eclipse.jst.server.core.PublishUtil for all methods, or rather org.eclipse.wst.server.core.PublishUtil (since it appears to have moved between 1.5.x and 2.0).  I only have WTP 1.5 tree checked out, I don't know if there is a viewcvs HTTP resource to cite more information so I can't see what the current WTP 2.0 PublishUtil looks like.

Set a breakpoint for java.io.File#createTempFile(String, File), modify a .jave file and save, do a publish with th JbossTools-AS driver.

If you open the source to the PublishUtil class and look for "temp".


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4094825#4094825

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4094825



More information about the jboss-user mailing list