<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
Adding org.apache.log4j and org.junit to nonAdvisablePackages
</h3>
<span style="margin-bottom: 10px;">
created by <a href="http://community.jboss.org/people/flavia.rainone%40jboss.com">Flavia Rainone</a> in <i>JBoss AOP Development</i> - <a href="http://community.jboss.org/message/533537#533537">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><p>I've just discovered that UserDefinedClassLoaderTestCase is failing for ages now and nobody ever noticed because another failure happens when Junit is printing the report.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>I've just fixed the initial failure, but I would also like to prevent the second failure to happen (i.e., if there is a failure, we want to to make sure we see that failure reported).</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>The cause of that second failure is an OutOfMemoryError, result of an endless instrumentation loop JBoss AOP enters because of calls to logger in JoinPointGenerator. Whenever such a call is found, JBoss AOP tries to weave the class. Since there was a problem in the classloader used by the test (fixed now), the class is not found and the same JoinPointGenerator try to log an error again, entering a infinite loop state.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Another problem that I saw is that, when Junit tries to generate the report, it uses org.junit packaged classes to do so, and JBoss AOP enters the loop again.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Despite the particularities of the aforementioned test, that was buggy, I think we should avoid weaving classes from those packages. Doing otherwise can:</p><p>- cause several deadlock problems because AOP startes the weaving process from inside the weaving process, in the case of org.apache.log4j (as seen before with other classes)</p><p>- cause problems when somebody is running a test that involves JBoss AOP with Junit, in the case of org.junit.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Can I add those packages to the isNonAdvisableClassName methods?</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/533537#533537">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in JBoss AOP Development at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2028">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>