<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
setRequiredStage should also setRequiredState
</h3>
<span style="margin-bottom: 10px;">
created by <a href="http://community.jboss.org/people/adrian%40jboss.org">Adrian Brock</a> in <i>JBoss Microcontainer Development</i> - <a href="http://community.jboss.org/message/534876#534876">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><p>This patch in OSGi shows that there is something wrong with AbstractDeploymentContext.setRequiredStage().</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>You shouldn't have to explicitly do the ControllerContext.setRequiredState(), that is an implementation detail.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Index: PackageAdminImpl.java<br/>===================================================================<br/>--- PackageAdminImpl.java    (revision 103305)<br/>+++ PackageAdminImpl.java    (working copy)<br/>@@ -347,6 +347,18 @@<br/>       {<br/>          log.error("Error resolving bundles: " + resolvableBundles, ex);<br/>          allResolved = false;<br/>+         <br/>+         // Reset the required state for bundles that didn't get resolved<br/>+         for (OSGiBundleState bundleState : resolvableBundles)<br/>+         {<br/>+            if (bundleState.getState() == Bundle.INSTALLED)<br/>+            {<br/>+               DeploymentUnit unit = bundleState.getDeploymentUnit();<br/>+               unit.setRequiredStage(DeploymentStages.DESCRIBE);<br/>+               ControllerContext ctx = unit.getAttachment(ControllerContext.class);<br/>+               ctx.setRequiredState(ControllerState.newState(DeploymentStages.DESCRIBE.getName()));<br/>+            }<br/>+         }<br/>       }<br/>       <br/>       return allResolved;</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/534876#534876">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in JBoss Microcontainer Development at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2115">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>