<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
JBREFLECT-5 - Implementing generics in JavassistClassInfo
</h3>
<span style="margin-bottom: 10px;">
reply from <a href="http://community.jboss.org/people/kabir.khan%40jboss.com">Kabir Khan</a> in <i>JBoss Microcontainer Development</i> - <a href="http://community.jboss.org/message/539885#539885">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><blockquote class="jive-quote"><p>I have tried turning off caching for these parameterized ClassInfos, which causes some of the tests to fail. From what I can see fixing them means having to adjust some of the tests to use assertEquals() instead of assertSame() for parameterized ClassInfos. I think this is necessary, and that the idea of enforcing object equality for parameterized ClassInfos is a misunderstanding :-)</p></blockquote><p>Apart from this local fix in BeanInfoCacheTestCase, all the other places that test object equality for parameterized class infos are in tests written by me as part of JBREFLECT-5, so I think I am safe to readjust the tests</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><div id="_mcePaste"> </div><pre class="jive-pre"><code class="jive-code">[kabir ~/sourcecontrol/jboss-reflect/trunk/jboss-reflect]
$svn diff src/test/
Index: src/test/java/org/jboss/test/beaninfo/test/BeanInfoCacheTestCase.java
===================================================================
--- src/test/java/org/jboss/test/beaninfo/test/BeanInfoCacheTestCase.java     (revision 104118)
+++ src/test/java/org/jboss/test/beaninfo/test/BeanInfoCacheTestCase.java     (working copy)
@@ -125,16 +125,45 @@
    {
       BeanInfo beanInfo = getConfiguration().getBeanInfo(typeInfo);
       ClassInfo typeInfo2 = beanInfo.getClassInfo();
-      assertSame(typeInfo, typeInfo2);
+      assertClassInfos(typeInfo, typeInfo2);
    }
-
+  
    private void assertClassInfo(ClassInfo typeInfo, String className, ClassLoader cl) throws Exception
    {
       BeanInfo beanInfo = getConfiguration().getBeanInfo(className, cl);
       ClassInfo typeInfo2 = beanInfo.getClassInfo();
-      assertSame(typeInfo, typeInfo2);
+      assertClassInfos(typeInfo, typeInfo2);
    }
+   private void assertClassInfos(TypeInfo typeA, TypeInfo typeB)
+   {
+      ClassInfo classA = assertInstanceOf(typeA, ClassInfo.class);
+      ClassInfo classB = assertInstanceOf(typeB, ClassInfo.class);
+     
+      if (classA.getRawType() == classA)
+         assertSame(classA, classB);
+      else
+      {
+         assertEquals(classA, classB);
+         TypeInfo[] argsA = classA.getActualTypeArguments();
+         TypeInfo[] argsB = classB.getActualTypeArguments();
+        
+         if (argsA != null)
+            assertNotNull(argsB);
+         if (argsB != null)
+            assertNotNull(argsA);
+         if (argsA == null)
+         {
+            assertNull(argsB);
+            return;
+         }
+        
+         assertEquals(argsA.length, argsB.length);
+         for (int i = 0 ; i < argsA.length ; i++)
+            assertClassInfos(argsA[i], argsB[i]);
+      }
+   }
+
    @SuppressWarnings("unchecked")
    protected Type getType(String type, Class<?> clazz) throws Exception
    {
</code></pre></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/539885#539885">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in JBoss Microcontainer Development at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2115">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>