<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
Wildcard support in Dynamic-imports
</h3>
<span style="margin-bottom: 10px;">
reply from <a href="http://community.jboss.org/people/warjort">Adrian Brock</a> in <i>JBoss Microcontainer Development</i> - <a href="http://community.jboss.org/message/546816#546816">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><p>Looks kind of ok. But...</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>1) You should use the delegate you just created NOT the module.</p><p>The operations on the module don't respect export restrictions, they can see private stuff.</p><p>Like I said before, you shouldn't be using those module operations. They are for debug purposes on the management console.</p><p>i.e. the request starts from that module which is not the case here.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>You want the operation to go through the delegate to the other policy with whatever export/import restrictions apply.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre><code>   <span style="color: navy;"><strong>protected</strong></span> DelegateLoader resolve(String pckg)<br/>   <span style="color: navy;">{</span><br/>      Requirement requirement = <span style="color: navy;"><strong>new</strong></span> PackageRequirement(pckg, range);<br/>      <span style="color: darkgreen;">// TODO -- add this DI to module? new DI impl to remove delegate from policy when resolved module goes away?</span><br/>      RequirementDependencyItem item = <span style="color: navy;"><strong>new</strong></span> RequirementDependencyItem(module, requirement, module.getClassLoaderState(), ControllerState.INSTALLED);<br/>      <span style="color: navy;"><strong>if</strong></span> (item.resolve(controller))<br/>      <span style="color: navy;">{</span><br/>         ClassLoaderPolicy policy = getPolicy();<br/>         <span style="color: darkgreen;">// TODO -- add delegate to policy</span><br/>         return delegate;<br/>      <span style="color: navy;">}</span><br/>      <span style="color: navy;"><strong>return</strong></span> null;<br/>   <span style="color: navy;">}</span></code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>2) I think you should return null for failures, I didn't check but I remember trying to write the internal handling of "not found" to not throw</p><p>ClassNotFoundExceptions all over the place. Throwing the RuntimeException would likely mean it doesn't go onto the next delegate?</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>3) You don't show how you are handling the undeploy of the dynamically resolved module when it is not shutdownPolicy=GarbageCollection.</p><p>It will move your ClassLoaderPolicy back to DESCRIBED since one of the dependencies has been removed. But I think you should also</p><p>remove the dynamic wildcard dependency items you will be adding in the first TODO shown above.</p><p>For shutdownPolicy=GarbageCollection you still need to do something in the Module to make the refreshPackages() stuff work properly.</p><p>For the GC policy used by OSGi, the dependsOnMe are tracked inside the Module rather than the DependencyInfo.</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/546816#546816">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in JBoss Microcontainer Development at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2115">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>