<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
Endless loop at AS server startup
</h3>
<span style="margin-bottom: 10px;">
reply from <a href="http://community.jboss.org/people/alesj">Ales Justin</a> in <i>JBoss Microcontainer Development</i> - <a href="http://community.jboss.org/message/549028#549028">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><blockquote class="jive-quote">The cache may have side effects because the code in #4 and #5 is not always executed when a client calls #3.<p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Could you please review carefully or alternatively change the algorithm so it becomes usable for large sets of reqs/caps and mods.</p></blockquote><p>Adding this patch doesn't change AS boot time in measurable way, at least not for default and all.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java">Index: classloading/src/main/java/org/jboss/classloading/spi/dependency/Module.java
===================================================================
--- classloading/src/main/java/org/jboss/classloading/spi/dependency/Module.java    (revision 106215)
+++ classloading/src/main/java/org/jboss/classloading/spi/dependency/Module.java    (working copy)
@@ -85,6 +85,9 @@
   
    <font color="darkgreen">/** The requirements */</font>
    <font color="navy"><b>private</b></font> List<RequirementDependencyItem> requirementDependencies;
+  
+   <font color="darkgreen">/** Already resolved dependency items */</font>
+   <font color="navy"><b>private</b></font> Map<RequirementDependencyItem, Module> resolved;
    <font color="darkgreen">/** Any lifecycle associated with the classloader */</font>
    <font color="navy"><b>private</b></font> LifeCycle lifeCycle;
@@ -94,7 +97,7 @@
   
    <font color="darkgreen">/** Requirements resolved to us */</font>
    <font color="navy"><b>private</b></font> Set<RequirementDependencyItem> depends = <font color="navy"><b>new</b></font> CopyOnWriteArraySet<RequirementDependencyItem>();
-  
+
    <font color="darkgreen">/**
     * Register a classloader for a module
     *
@@ -1191,6 +1194,7 @@
             addIDependOn(item);
             requirementDependencies.add(item);
          }
+         resolved = new ConcurrentHashMap<RequirementDependencyItem, Module>();
       }
    }
@@ -1205,6 +1209,7 @@
             removeIDependOn(item);
       }
       requirementDependencies = null;
+      resolved = null;
    }
    /**
@@ -1216,7 +1221,10 @@
       if (requirementDependencies != null && requirementDependencies.isEmpty() == false)
       {
          for (RequirementDependencyItem item : requirementDependencies)
+         {
             item.unresolved(controller);
+            resolved.remove(item);
+         }
       }
    }
@@ -1336,14 +1344,33 @@
     */</font>
    <font color="navy"><b>protected</b></font> Module resolveModule(RequirementDependencyItem dependency, <font color="navy"><b>boolean</b></font> resolveSpace)
    <font color="navy">{</font>
+      <font color="navy"><b>if</b></font> (resolved != <font color="navy"><b>null</b></font>)
+      <font color="navy">{</font>
+         Module resolvedModule = resolved.get(dependency);
+         <font color="navy"><b>if</b></font> (resolvedModule != <font color="navy"><b>null</b></font>)
+            <font color="navy"><b>return</b></font> resolvedModule;
+      <font color="navy">}</font>
+
       ClassLoadingSpace space = getClassLoadingSpace();
       <font color="navy"><b>if</b></font> (resolveSpace && space != <font color="navy"><b>null</b></font>)
          space.resolve(<font color="navy"><b>this</b></font>);
+      <font color="navy"><b>if</b></font> (resolved != <font color="navy"><b>null</b></font>)
+      <font color="navy">{</font>
+         Module resolvedModule = resolved.get(dependency);
+         <font color="navy"><b>if</b></font> (resolvedModule != <font color="navy"><b>null</b></font>)
+            <font color="navy"><b>return</b></font> resolvedModule;
+      <font color="navy">}</font>
+
       Requirement requirement = dependency.getRequirement();
-      <font color="navy"><b>return</b></font> checkDomain().resolveModule(this, requirement);
+      Module result = checkDomain().resolveModule(this, requirement);
+
+      <font color="navy"><b>if</b></font> (result != <font color="navy"><b>null</b></font> && resolved != <font color="navy"><b>null</b></font>)
+         resolved.put(dependency, result);
+
+      <font color="navy"><b>return</b></font> result;
    <font color="navy">}</font>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><blockquote class="jive-quote">Perhaps these large sets should be mocked in the CL testsuite.</blockquote><p>But I guess, as you mentioned, it will only show in osgi config, with compendiums large requirement set.</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/549028#549028">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in JBoss Microcontainer Development at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2115">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>