<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">JBoss Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
Metadata design - xsds
</h3>
<span style="margin-bottom: 10px;">
created by <a href="http://community.jboss.org/people/maeste">Stefano Maestri</a> in <i>JCA Development</i> - <a href="http://community.jboss.org/message/552535#552535">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><p>Hi All,</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>I'm designing our new metadatas layer and I've imported in the projects XSDs form jboss-metadata-rar.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>I've started with jboss-ra_2_0.xsd and I've already done some changes to that one I'd like to share with you because it would guidelines I'd like to follow in next future for our own XSDs (i.e. not included in JCA specs):</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code">
diff --git a/common/src/main/resources/schema/jboss-ra_2_0.xsd b/common/src/main/resources/schema/jboss-ra_2_0.xsd
index b8f86cc..3b53927 100644
--- a/common/src/main/resources/schema/jboss-ra_2_0.xsd
+++ b/common/src/main/resources/schema/jboss-ra_2_0.xsd
@@ -5,12 +5,9 @@
     xmlns:javaee="http://java.sun.com/xml/ns/javaee"
     elementFormDefault="qualified" attributeFormDefault="unqualified" version="2.0">
-
-    <xs:import namespace="http://java.sun.com/xml/ns/javaee" schemaLocation="http://java.sun.com/xml/ns/javaee/javaee_5.xsd"/>
-   
-    <xs:element name="jboss-ra" type="ra:jbossRaType"/>                             
+    <xs:element name="jboss-ra" type="ra:jboss-ra-type"/>                             
    
-    <xs:complexType name="jbossRaType">          
+    <xs:complexType name="jboss-ra-type">          
        
         <xs:sequence>
             <xs:element name="ra-config-property" type="ra:ra-config-property-type" minOccurs="0" maxOccurs="unbounded"/> 
@@ -26,10 +23,10 @@
         <xs:sequence>
             <xs:element name="ra-config-property-name" type="xs:string" minOccurs="1" maxOccurs="1"/>
-            <xs:element name="ra-config-property-type" type="ra:ra-config-property-typeType" minOccurs="1" maxOccurs="1"/>
+            <xs:element name="ra-config-property-type" type="ra:ra-config-property-type-type" minOccurs="1" maxOccurs="1"/>
             <xs:element name="ra-config-property-value" type="xs:string" minOccurs="0" maxOccurs="1"/>
         </xs:sequence>
-        <xs:attribute name="override-element" type="xs:string" default="resourceadapter"/>
+        <xs:attribute name="override-element" type="ra:override-element-type" default="resourceadapter"/>
     </xs:complexType>
      <xs:complexType name="bean-validation-groups-type">
@@ -45,31 +42,27 @@
        </xs:sequence>
      </xs:complexType>
     
-      <xs:complexType name="ra-config-property-typeType">
-         <xs:simpleContent>
-           <xs:restriction base="javaee:string">
-              <xs:enumeration value="java.lang.Boolean"/>
-              <xs:enumeration value="java.lang.String"/>
-              <xs:enumeration value="java.lang.Integer"/>
-              <xs:enumeration value="java.lang.Double"/>
-              <xs:enumeration value="java.lang.Byte"/>
-              <xs:enumeration value="java.lang.Short"/>
-              <xs:enumeration value="java.lang.Long"/>
-              <xs:enumeration value="java.lang.Float"/>
-              <xs:enumeration value="java.lang.Character"/>
-           </xs:restriction>
-         </xs:simpleContent>
-      </xs:complexType>
+      <xs:simpleType name="ra-config-property-type-type">
+          <xs:restriction base="xs:token">
+            <xs:enumeration value="java.lang.Boolean"/>
+            <xs:enumeration value="java.lang.String"/>
+            <xs:enumeration value="java.lang.Integer"/>
+            <xs:enumeration value="java.lang.Double"/>
+            <xs:enumeration value="java.lang.Byte"/>
+            <xs:enumeration value="java.lang.Short"/>
+            <xs:enumeration value="java.lang.Long"/>
+            <xs:enumeration value="java.lang.Float"/>
+            <xs:enumeration value="java.lang.Character"/>
+          </xs:restriction>
+      </xs:simpleType>
      
-      <xs:complexType name="override-elementType">
-        <xs:simpleContent>
-          <xs:restriction base="javaee:string">
+      <xs:simpleType name="override-element-type">
+          <xs:restriction base="xs:token">
             <xs:enumeration value="connection-definition"/>
             <xs:enumeration value="resourceadapter"/>
             <xs:enumeration value="activationspec"/>
             <xs:enumeration value="adminobject"/>
             <xs:enumeration value="authentication-mechanism"/>
           </xs:restriction>
-        </xs:simpleContent>
-      </xs:complexType>     
+      </xs:simpleType>     
</xs:schema>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>As you can see above what I've basically done is</p><ol><li>removing dependency from j2ee schema. It was used just for j2ee:string that is an xs:token. I think using xs:token keep xsd more readable and easy to understand. Moreover it is the important to build enumeration type as xs:simpleType and so making possible to use them also for attribute type</li><li>Use of simpletype where it is possible for enumeration making possible to use them for attributes type</li><li>All element name and type name are lower case</li></ol><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>I have elaborated a bit more on this xsd, and I think a great enhancement we can is to define type for ra-config-property at xsd level instead of define 2 different element to express value and type. IOW doing this changes to previous xsd</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-xml">
diff --git a/common/src/main/resources/schema/jboss-ra_2_0.xsd b/common/src/main/resources/schema/jboss-ra_2_0.xsd
index 08c5e17..58572d9 100644
--- a/common/src/main/resources/schema/jboss-ra_2_0.xsd
+++ b/common/src/main/resources/schema/jboss-ra_2_0.xsd
@@ -23,8 +23,17 @@
         <span class="jive-xml-tag"><xs:sequence></span>
             <span class="jive-xml-tag"><xs:element name="ra-config-property-name" type="xs:token" minOccurs="1" maxOccurs="1"/></span>
-            <span class="jive-xml-tag"><xs:element name="ra-config-property-type" type="ra:ra-config-property-type-type" minOccurs="1" maxOccurs="1"/></span>
-            <span class="jive-xml-tag"><xs:element name="ra-config-property-value" type="xs:token" minOccurs="0" maxOccurs="1"/></span>
+            <span class="jive-xml-tag"><xs:choice></span>
+                <span class="jive-xml-tag"><xs:element name="ra-config-property-booelan" type="xs:boolean" minOccurs="0" maxOccurs="1"/></span>
+                <span class="jive-xml-tag"><xs:element name="ra-config-property-string" type="xs:string" minOccurs="0" maxOccurs="1"/></span>
+                <span class="jive-xml-tag"><xs:element name="ra-config-property-integer" type="xs:integer" minOccurs="0" maxOccurs="1"/></span>
+                <span class="jive-xml-tag"><xs:element name="ra-config-property-double" type="xs:double" minOccurs="0" maxOccurs="1"/></span>
+                <span class="jive-xml-tag"><xs:element name="ra-config-property-byte" type="xs:byte" minOccurs="0" maxOccurs="1"/></span>
+                <span class="jive-xml-tag"><xs:element name="ra-config-property-short" type="xs:short" minOccurs="0" maxOccurs="1"/></span>
+                <span class="jive-xml-tag"><xs:element name="ra-config-property-long" type="xs:long" minOccurs="0" maxOccurs="1"/></span>
+                <span class="jive-xml-tag"><xs:element name="ra-config-property-float" type="xs:float" minOccurs="0" maxOccurs="1"/></span>
+                <span class="jive-xml-tag"><xs:element name="ra-config-property-char" type="ra:char" minOccurs="0" maxOccurs="1"/></span>
+            <span class="jive-xml-tag"></xs:choice></span>
         <span class="jive-xml-tag"></xs:sequence></span>
         <span class="jive-xml-tag"><xs:attribute name="override-element" type="ra:override-element-type" default="resourceadapter"/></span>
     <span class="jive-xml-tag"></xs:complexType></span>
@@ -42,20 +51,13 @@
        <span class="jive-xml-tag"></xs:sequence></span>
      <span class="jive-xml-tag"></xs:complexType></span>
-      <span class="jive-xml-tag"><xs:simpleType name="ra-config-property-type-type"></span>
-          <span class="jive-xml-tag"><xs:restriction base="xs:token"></span>
-            <span class="jive-xml-tag"><xs:enumeration value="java.lang.Boolean"/></span>
-            <span class="jive-xml-tag"><xs:enumeration value="java.lang.String"/></span>
-            <span class="jive-xml-tag"><xs:enumeration value="java.lang.Integer"/></span>
-            <span class="jive-xml-tag"><xs:enumeration value="java.lang.Double"/></span>
-            <span class="jive-xml-tag"><xs:enumeration value="java.lang.Byte"/></span>
-            <span class="jive-xml-tag"><xs:enumeration value="java.lang.Short"/></span>
-            <span class="jive-xml-tag"><xs:enumeration value="java.lang.Long"/></span>
-            <span class="jive-xml-tag"><xs:enumeration value="java.lang.Float"/></span>
-            <span class="jive-xml-tag"><xs:enumeration value="java.lang.Character"/></span>
-          <span class="jive-xml-tag"></xs:restriction></span>
-      <span class="jive-xml-tag"></xs:simpleType></span>
-     
+     <span class="jive-xml-tag"><xsi:simpleType name="char"></span>
+      <span class="jive-xml-tag"><xsi:restriction base="xsi:string"></span>
+        <span class="jive-xml-tag"><xsi:maxLength value="1"/></span>
+        <span class="jive-xml-tag"><xsi:minLength value="1"/></span>
+      <span class="jive-xml-tag"></xsi:restriction></span>
+    <span class="jive-xml-tag"></xsi:simpleType></span>
+   
       <span class="jive-xml-tag"><xs:simpleType name="override-element-type"></span>
           <span class="jive-xml-tag"><xs:restriction base="xs:token"></span>
             <span class="jive-xml-tag"><xs:enumeration value="connection-definition"/></span>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>As you can see the xsd is a bit more verbose, and parsing it will be too. But IMHO it drives to more readable config files and give us the opportunity to effective validate xml and values before èarsing if we decide to.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Look forward for your feedback</p><p>S</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/552535#552535">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in JCA Development at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2099">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>