<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">JBoss Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
Re: Constructor Execution Pointcut Causing ArrayOutOfBounds
</h3>
<span style="margin-bottom: 10px;">
created by <a href="http://community.jboss.org/people/nwhitehead">Nicholas Whitehead</a> in <i>JBoss AOP</i> - <a href="http://community.jboss.org/message/564667#564667">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><p>Hello Kabir;</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Thanks for the response.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>I hope the fact that no one is working on JBoss AOP right now is because it is complete and stable. Not being deprecated is it ?</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>After some more investigation and some simplified test cases, I have determined that the issue arises in this specific set of conditions:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><ol><li>An execution pointcut on private constructors.</li><li>An advised class that has a private parameterless constructor and one or more parameterized private constructors.</li></ol><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>If the constructors are not private, or there is only a single private parameterless constructor, the error does not occur.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>There are probably a number of other combinations of conditions, but I believe my patch should work for all for them and not break anything.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>The issue is on line 1870 of <strong>org.jboss.aop.Advisor</strong> in JBoss AOP 2.1.8 GA. The line of code is:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p><span style="color: #0000ff; font-family: courier new,courier; "><strong>pointcutResolved(constructorInfos[i], binding, new ConstructorJoinpoint(constructor));</strong></span></p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>My patch, which is very simplistic, replaces this line with:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p><strong style=": ; color: #0000ff; font-family: courier new,courier; ">for(ConstructorInfo ci: constructorInfos) {<br/>   if(constructor.equals(ci.getConstructor())) {<br/>      pointcutResolved(ci, binding, new ConstructorJoinpoint(constructor));<br/>      break;<br/>   }<br/>   throw new NotImplementedException(</strong></p><p><strong style=": ; color: #0000ff; font-family: courier new,courier; ">        "Failed to match ConstructorInfo for Constructor [" + constructor.toGenericString() + "]");<br/> }</strong></p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>The premise is that in this condition, the array of Constructors is not the same size as the array of ConstructorInfos, so we cannot use a simple index reference. Iterating through the available ConstructorInfos find the matching one and then executes the pointcutResolved normally. Not sure if the thrown exception is JBoss compliant, but I am also not sure if it will realistically ever reach that line anyways.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>At any rate, let me know what I can do to submit this patch if you need something more formal.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Cheers.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>//Nicholas</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/564667#564667">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in JBoss AOP at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2027">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>