<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">JBoss Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
[jBPM4.4] custom activity has an end time before this activity is leaveds the activity
</h3>
<span style="margin-bottom: 10px;">
created by <a href="http://community.jboss.org/people/saig0">saig0</a> in <i>jBPM</i> - <a href="http://community.jboss.org/message/600020#600020">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><p>Hi,</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>I note that a custom activity has an end time before this activity is leaved. </p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>process:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-xml"><span class="jive-xml-tag"><?xml version="1.0" encoding="UTF-8"?></span>
<span class="jive-xml-tag"><span><process name="HistoryServiceTest" xmlns="</span><a class="jive-link-external-small" href="http://jbpm.org/4.4/jpdl" target="_blank">http://jbpm.org/4.4/jpdl</a><span>"></span></span>
          <span class="jive-xml-tag"><start name="start" g="77,144,48,48"></span>
                    <span class="jive-xml-tag"><transition to="custom-state" /></span>
          <span class="jive-xml-tag"></start></span>
          <span class="jive-xml-tag"><custom name="custom-state" g="175,140,105,52" class="processes.classes.SimpleCustomState"></span>
                    <span class="jive-xml-tag"><transition to="end" /></span>
          <span class="jive-xml-tag"></custom></span>
          <span class="jive-xml-tag"><end name="end" g="324,144,48,48" /></span>
<span class="jive-xml-tag"></process></span>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>SimpleCustomState.java:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java"><font color="navy"><b>package</b></font> processes.classes;
 
<font color="navy"><b>import</b></font> java.util.Map;
<font color="navy"><b>import</b></font> org.jbpm.api.activity.ActivityExecution;
<font color="navy"><b>import</b></font> org.jbpm.api.activity.ExternalActivityBehaviour;
 
<font color="navy"><b>public</b></font> <font color="navy"><b>class</b></font> SimpleCustomState <font color="navy"><b>implements</b></font> ExternalActivityBehaviour
<font color="navy">{</font>
    <font color="navy"><b>private</b></font> <font color="navy"><b>static</b></font> <font color="navy"><b>final</b></font> <font color="navy"><b>long</b></font> serialVersionUID = 1L;
 
    <font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> execute(ActivityExecution execution) <font color="navy"><b>throws</b></font> Exception    <font color="navy">{</font>
        execution.waitForSignal();
    <font color="navy">}</font>
 
    <font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> signal(ActivityExecution execution, String signalName, Map<String, ?> parameters)
            <font color="navy"><b>throws</b></font> Exception    <font color="navy">{</font>
        execution.takeDefaultTransition();
    <font color="navy">}</font>
 
<font color="navy">}</font>
 
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>test:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java"><font color="navy"><b>package</b></font> services;
 
<font color="navy"><b>import</b></font> org.junit.Assert.*;
<font color="navy"><b>import</b></font> java.util.Date;
<font color="navy"><b>import</b></font> java.util.List;
<font color="navy"><b>import</b></font> java.util.zip.ZipInputStream; 
<font color="navy"><b>import</b></font> org.jbpm.api.*;
<font color="navy"><b>import</b></font> org.junit.*;
 
<font color="navy"><b>public</b></font> <font color="navy"><b>class</b></font> HistoryServiceTest
<font color="navy">{</font>
    <font color="navy"><b>private</b></font> HistoryService    historyService;
    <font color="navy"><b>private</b></font> ExecutionService  executionService;
    <font color="navy"><b>private</b></font> RepositoryService repositoryService;
 
    @Before
    <font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> setup()    <font color="navy">{</font>
        initEngine();
        deployProcess();
    <font color="navy">}</font>
 
    <font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> initEngine()    <font color="navy">{</font>
        ProcessEngine processEngine = <font color="navy"><b>new</b></font> Configuration().setResource(<font color="red">"default.jbpm.cfg.xml"</font>)
                .buildProcessEngine();
        executionService = processEngine.getExecutionService();
        historyService = processEngine.getHistoryService();
        repositoryService = processEngine.getRepositoryService();
    <font color="navy">}</font>
 
    <font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> deployProcess()    <font color="navy">{</font>
        ZipInputStream zipInputStream = <font color="navy"><b>new</b></font> ZipInputStream(getClass().getResourceAsStream(<font color="red">"/jbpm.zip"</font>));
        repositoryService.createDeployment().addResourcesFromZipInputStream(zipInputStream).setName(<font color="red">"test"</font>)
                .setTimestamp(<font color="navy"><b>new</b></font> Date().getTime()).deploy();
    <font color="navy">}</font>
 
    <font color="navy"><b>public</b></font> String startProcess()    <font color="navy">{</font>
        ProcessInstance processInstance = executionService.startProcessInstanceByKey(<font color="red">"HistoryServiceTest"</font>);
        <font color="navy"><b>return</b></font> processInstance.getId();
    <font color="navy">}</font>
 
    <font color="navy"><b>private</b></font> <font color="navy"><b>boolean</b></font> isRunning(String processInstanceId)    <font color="navy">{</font>
        ProcessInstance pi = executionService.findProcessInstanceById(processInstanceId);
        <font color="navy"><b>return</b></font> pi != <font color="navy"><b>null</b></font> ? pi.isEnded() : <font color="navy"><b>false</b></font>;
    <font color="navy">}</font>
 
    @Test
    <font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> testHasEndDateForEndedCustomActivity()    <font color="navy">{</font>
        String processInstanceId = startProcess();
        String activityName = <font color="red">"custom-state"</font>;
        assertTrue(executionService.findProcessInstanceById(processInstanceId).isActive(activityName));
 
 
        executionService.signalExecutionById(processInstanceId, <font color="red">""</font>);
        assertFalse(isRunning(processInstanceId));
 
 
        HistoryActivityInstance historyActivityInstance = historyService.createHistoryActivityInstanceQuery()
                .processInstanceId(processInstanceId).activityName(activityName).uniqueResult();
        assertNotNull(historyActivityInstance.getEndTime());
    <font color="navy">}</font>
 
    @Test
    <font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> testHasNoEndDateForActiveCustomActivity()    <font color="navy">{</font>
        String processInstanceId = startProcess();
        String activityName = <font color="red">"custom-state"</font>;
        assertTrue(executionService.findProcessInstanceById(processInstanceId).isActive(activityName));
 
 
        List<HistoryActivityInstance> historyActivityInstances = historyService
                .createHistoryActivityInstanceQuery().processInstanceId(processInstanceId)
                .activityName(activityName).list();
        <font color="navy"><b>if</b></font> (!historyActivityInstances.isEmpty())
        <font color="navy">{</font>
            <font color="navy"><b>for</b></font> (HistoryActivityInstance historyActivityInstance : historyActivityInstances)
                assertNull(historyActivityInstance.getEndTime()); <font color="darkgreen">// this fail!</font>
        <font color="navy">}</font>
    <font color="navy">}</font>
<font color="navy">}</font>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>After I looking for a reason, I found something in class UserCodeActivityBehaviour:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java"><font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> execute(ActivityExecution execution) <font color="navy"><b>throws</b></font> Exception <font color="navy">{</font>
    ActivityBehaviour activityBehaviour = (ActivityBehaviour) customActivityReference.getObject(execution);
    activityBehaviour.execute(execution);
    ((ExecutionImpl)execution).historyAutomatic();
  <font color="navy">}</font>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>This methode create a object of class HistoryActivityInstanceImpl and call:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java"><font color="navy"><b>public</b></font> HistoryAutomaticInstanceImpl(HistoryProcessInstance historyProcessInstanceImpl, ExecutionImpl execution) <font color="navy">{</font>
    <font color="navy"><b>super</b></font>(historyProcessInstanceImpl, execution);
    setEndTime(Clock.getTime());
  <font color="navy">}</font>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Now I want to ask why this was not implemented like in class StateActivity?</p><p>And how to fix this bug?</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/600020#600020">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in jBPM at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2034">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>