<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">JBoss Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
jBPM JUnit tests are failing
</h3>
<span style="margin-bottom: 10px;">
created by <a href="http://community.jboss.org/people/michael.wagner">Michael Wagner</a> in <i>jBPM</i> - <a href="http://community.jboss.org/message/616326#616326">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><p>Hi,</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>I have downloaded the junit tests from:</p><p><a class="jive-link-external-small" href="http://sourceforge.net/projects/jbpm/files/jBPM%205/jbpm-5.1.0.Final/jbpm-5.1.0.Final-examples.zip/download" target="_blank">http://sourceforge.net/projects/jbpm/files/jBPM%205/jbpm-5.1.0.Final/jbpm-5.1.0.Final-examples.zip/download</a></p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>First: big thank you for providing so many unit tests! Makes is absolutly clear how to use the api.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Running JBPM2UnitTests.java gives me always one failure in testTimerStart:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java">junit.framework.AssertionFailedError: expected:<5> but was:<4>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>"Correcting" the value to 4 gives a failure in testTimerStartCron:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java">junit.framework.AssertionFailedError: expected:<5> but was:<6>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>"Correcting" the value here to 6 gives no more failures any more.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java">     <font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> testTimerStartCron() <font color="navy"><b>throws</b></font> Exception <font color="navy">{</font>
        KnowledgeBase kbase = createKnowledgeBase(<font color="red">"BPMN2-TimerStartCron.bpmn2"</font>);
          StatefulKnowledgeSession ksession = createKnowledgeSession(kbase);
          <font color="navy"><b>final</b></font> List list = <font color="navy"><b>new</b></font> ArrayList();
          ksession.addEventListener(<font color="navy"><b>new</b></font> DefaultProcessEventListener() <font color="navy">{</font>
               <font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> afterProcessStarted(ProcessStartedEvent event) <font color="navy">{</font>
                    list.add(event.getProcessInstance().getId());
               <font color="navy">}</font>
          <font color="navy">}</font>);
          Thread.sleep(500);
        <font color="navy"><b>for</b></font> (<font color="navy"><b>int</b></font> i = 0; i < 5; i++) <font color="navy">{</font>
             ksession.fireAllRules();
             Thread.sleep(1000);
        <font color="navy">}</font>
        assertEquals(6, list.size());
    <font color="navy">}</font>
   
    <font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> testTimerStart() <font color="navy"><b>throws</b></font> Exception <font color="navy">{</font>
        KnowledgeBase kbase = createKnowledgeBase(<font color="red">"BPMN2-TimerStart.bpmn2"</font>);
          StatefulKnowledgeSession ksession = createKnowledgeSession(kbase);
          <font color="navy"><b>final</b></font> List list = <font color="navy"><b>new</b></font> ArrayList();
          ksession.addEventListener(<font color="navy"><b>new</b></font> DefaultProcessEventListener() <font color="navy">{</font>
               <font color="navy"><b>public</b></font> <font color="navy"><b>void</b></font> afterProcessStarted(ProcessStartedEvent event) <font color="navy">{</font>
                    list.add(event.getProcessInstance().getId());
               <font color="navy">}</font>
          <font color="navy">}</font>);
          Thread.sleep(250);
          assertEquals(0, list.size());
        <font color="navy"><b>for</b></font> (<font color="navy"><b>int</b></font> i = 0; i < 5; i++) <font color="navy">{</font>
             ksession.fireAllRules();
             Thread.sleep(500);
        <font color="navy">}</font>
        assertEquals(4, list.size());
    <font color="navy">}</font>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Besides that I cannot understand the values by reading the code: what I definitively do not understand is: how can somebody write tests depending on a "Thread.sleep"? Are there no events one could wait for? This gives a situation which is not deterministic! This is because time is not processor time.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Please tell me how the junit tests in these cases could be re-written in a deterministic way.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>We are in an automotive area and cannot affort to run software which can not be testet in a deterministic way.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Michael</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/616326#616326">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in jBPM at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2034">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>