<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="https://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">JBoss Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
Drools Spring Integration, errors in DroolsSpringTransactionManager
</h3>
<span style="margin-bottom: 10px;">
created by <a href="https://community.jboss.org/people/jbize">John Bize</a> in <i>jBPM</i> - <a href="https://community.jboss.org/message/751900#751900">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><p>I have an application that integrates jBPM, Spring, Hibernate/JPA, JPA2, and Richfaces4.  It's mostly working ok, except sometimes I am/was getting NullPointer exceptions from the DroolsSpringTransactionManager.  I'm using drools-spring 5.3.1.Final.  This class is apparently a (broken?) wrapper class around (in my case), the org.springframework.orm.jpa.JpaTransactionManager.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Looking at the source code, I observed several things. There is an obvious bug in the begin() method in that if the call to getStatus() returns STATUS_NO_TRANSACTION, which it will if the wrapped tm (ptm) is null, it immediately dereferences the null ptm. (this.ptm.getTransaction(td)).  I'm not too woried about this one as it seems rather unlikely.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>What's happening for me (in the getStatus() method) is that it's making the call "transaction = this.ptm.getTransaction(td);" which is occasionally throwing an "IllegalStateException: Transaction already active," wrapped in an outer RuntimeException and dropping down to the finally block.  There, the still null transaction is committed, throwing an NPE that masks the original exception.  To mitigate this, I added a catch RuntimeException and if the cause is an IllegalStateException, I return STATUS_UNKNOWN.  In the finally block, I also ensure that I don't try to commit a null transaction.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p><span>Clearly this code is fragile, and </span><a class="jive-link-external-small" href="https://issues.jboss.org/browse/JBRULES-2791" target="_blank">https://issues.jboss.org/browse/JBRULES-2791</a><span> is probably correct, but </span><strong>can anyone suggest why I'm sometimes getting the "IllegalStateException: Transaction already active" exceptions in the first place.  I am using 4 separate persistence units (and transaction managers), two for basic components of my application, one for the jBPM process tables, and one for the LocalTaskManager Task tables.</strong></p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p><span>Copying the code from: </span><a class="jive-link-external-small" href="https://github.com/droolsjbpm/droolsjbpm-integration/blob/master/drools-container/drools-spring/src/main/java/org/drools/container/spring/beans/persistence/DroolsSpringTransactionManager.java" target="_blank">https://github.com/droolsjbpm/droolsjbpm-integration/blob/master/drools-container/drools-spring/src/main/java/org/drools/container/spring/beans/persistence/DroolsSpringTransactionManager.java</a><span>, my mitigating changes are in red (typed, not copied):</span></p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code">
public class DroolsSpringTransactionManager
    implements
    TransactionManager {
    Logger                                     logger             = LoggerFactory.getLogger( getClass() );
    private AbstractPlatformTransactionManager ptm;
    TransactionDefinition                      td                 = new DefaultTransactionDefinition();
    TransactionStatus                          currentTransaction = null;
    public DroolsSpringTransactionManager(AbstractPlatformTransactionManager ptm) {
        this.ptm = ptm;
    }
    public boolean begin() {
        try {
            if ( getStatus() == TransactionManager.STATUS_NO_TRANSACTION ) {
                // If there is no transaction then start one, we will commit within the same Command
                // it seems in spring calling getTransaction is enough to begin a new transaction
                currentTransaction = this.ptm.getTransaction( td );
                return true;
            } else {
                return false;
            }
        } catch ( Exception e ) {
            logger.warn( "Unable to begin transaction",
                         e );
            throw new RuntimeException( "Unable to begin transaction",
                                        e );
        }
    }
    public void commit(boolean transactionOwner) {
        if ( transactionOwner ) {
            try {
                // if we didn't begin this transaction, then do nothing
                this.ptm.commit( currentTransaction );
                currentTransaction = null;
            } catch ( Exception e ) {
                logger.warn( "Unable to commit transaction",
                             e );
                throw new RuntimeException( "Unable to commit transaction",
                                            e );
            }
        }
    }
    public void rollback(boolean transactionOwner) {
        try {
            if ( transactionOwner ) {
                this.ptm.rollback( currentTransaction );
                currentTransaction = null;
            }
        } catch ( Exception e ) {
            logger.warn( "Unable to rollback transaction",
                         e );
            throw new RuntimeException( "Unable to rollback transaction",
                                        e );
        }
    }
    /**
     * Borrowed from Seam
     */
    public int getStatus() {
        if ( ptm == null ) {
            return TransactionManager.STATUS_NO_TRANSACTION;
        }
        logger.debug( "Current TX name (According to TransactionSynchronizationManager) : " + TransactionSynchronizationManager.getCurrentTransactionName() );
        if ( TransactionSynchronizationManager.isActualTransactionActive() ) {
            TransactionStatus transaction = null;
            try {
                if ( currentTransaction == null ) {
                    transaction = ptm.getTransaction( td );
                    if ( transaction.isNewTransaction() ) {
                        return TransactionManager.STATUS_COMMITTED;
                    }
                } else {
                    transaction = currentTransaction;
                }
                logger.debug( "Current TX: " + transaction );
                // If SynchronizationManager thinks it has an active transaction but
                // our transaction is a new one
                // then we must be in the middle of committing
                if ( transaction.isCompleted() ) {
                    if ( transaction.isRollbackOnly() ) {
                        return TransactionManager.STATUS_ROLLEDBACK;
                    }
                    return TransactionManager.STATUS_COMMITTED;
                } else {
                    // Using the commented-out code in means that if rollback with this manager,
                    //  I always have to catch and check the exception
                    //  because ROLLEDBACK can mean both "rolled back" and "rollback only".
                    // if ( transaction.isRollbackOnly() ) {
                    //     return TransactionManager.STATUS_ROLLEDBACK;
                    // }
                   
                    return TransactionManager.STATUS_ACTIVE;
                }
{color:#f00}
            } catch (RuntimeException e) {
                if ( e.getCause() instanceof IllegalStateException ) {
                    logger.debug( "IllegalStateException in getStatus()", e );
                    return TransactionManager.STATUS_UNKNOWN;
                } else {
                    logger.debug( "Unexpected Exception in getStatus()", e );
                    throw e;
                }
{color}
            } finally {
                if ( currentTransaction == null ) {
{color:#f00}
                    if (transaction != null) {
{color}
                      ptm.commit( transaction );
{color:#f00}
                    }
{color}
                }
            }
        }
        return TransactionManager.STATUS_NO_TRANSACTION;
    }
    public void registerTransactionSynchronization(TransactionSynchronization ts) {
        TransactionSynchronizationManager.registerSynchronization( new SpringTransactionSynchronizationAdapter( ts ) );
    }
}
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="https://community.jboss.org/message/751900#751900">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in jBPM at <a href="https://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2034">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>