[jbosscache-commits] JBoss Cache SVN: r5652 - in core/trunk/src/main/java/org/jboss/cache: interceptors and 1 other directory.

[jbosscache-commits at lists.jboss.org]

Author: mircea.markus
Date: 2008-04-24 04:51:02 -0400 (Thu, 24 Apr 2008)
New Revision: 5652

Modified:
   core/trunk/src/main/java/org/jboss/cache/commands/functional/MarshallableCommand.java
   core/trunk/src/main/java/org/jboss/cache/commands/functional/TxCacheCommand.java
   core/trunk/src/main/java/org/jboss/cache/interceptors/TxInterceptor.java
Log:
JBCACHE-1222 - added todos

Modified: core/trunk/src/main/java/org/jboss/cache/commands/functional/MarshallableCommand.java
===================================================================
--- core/trunk/src/main/java/org/jboss/cache/commands/functional/MarshallableCommand.java	2008-04-23 14:41:36 UTC (rev 5651)
+++ core/trunk/src/main/java/org/jboss/cache/commands/functional/MarshallableCommand.java	2008-04-24 08:51:02 UTC (rev 5652)
@@ -22,6 +22,7 @@
    Object[] getParameters();
 
    /**
+    * todo - [mmarkus] rename is setParameters as this is oposit to getParamaters
     * Sets the state of a command instance with unmarshalled command id and args.
     *
     * @param commandId command id to set.  This is usually unused but *could* be used in the event of a command having multiple IDs, such as {@link org.jboss.cache.commands.cachedata.PutKeyValueCommand}.

Modified: core/trunk/src/main/java/org/jboss/cache/commands/functional/TxCacheCommand.java
===================================================================
--- core/trunk/src/main/java/org/jboss/cache/commands/functional/TxCacheCommand.java	2008-04-23 14:41:36 UTC (rev 5651)
+++ core/trunk/src/main/java/org/jboss/cache/commands/functional/TxCacheCommand.java	2008-04-24 08:51:02 UTC (rev 5652)
@@ -7,6 +7,7 @@
  *
  * @author Mircea.Markus at jboss.com
  * @since 2.2
+ * todo [mmarkus] revisit this and consider removing it as the GTX is already in the command through the invocation context
  */
 public interface TxCacheCommand extends CacheCommand
 {

Modified: core/trunk/src/main/java/org/jboss/cache/interceptors/TxInterceptor.java
===================================================================
--- core/trunk/src/main/java/org/jboss/cache/interceptors/TxInterceptor.java	2008-04-23 14:41:36 UTC (rev 5651)
+++ core/trunk/src/main/java/org/jboss/cache/interceptors/TxInterceptor.java	2008-04-24 08:51:02 UTC (rev 5652)
@@ -970,6 +970,7 @@
     */
    private CacheCommand replaceGtx(CacheCommand m, final GlobalTransaction gtx) throws Throwable
    {
+      //todo add this visitor locally
       globalTransactionCommandsVisitor = new GlobalTransactionCommandsVisitor()
       {
          public Object handleGlobalTransactionCommands(GlobalTransactionCommand command)