<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; ">Looks great!<DIV><BR class="khtml-block-placeholder"></DIV><DIV>One Q though - about the specific config impls for CacheLoaders, etc., do we really want them as inner classes, e.g., org.jboss.cache.loader.FileCacheLoader$Config? From a Java standpoint, this makes the most sense and is cleanest, can't say I like the String representation of the inner class in XML though. :-) Just me being a pedant, but isn't org.jboss.cache.loader.FileCacheLoaderConfig better, sure this means 2 .java files per cache loader, but still?</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Cheers,<BR><DIV> <SPAN class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><SPAN class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><SPAN class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><DIV>--</DIV><DIV>Manik Surtani</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Lead, JBoss Cache</DIV><DIV>JBoss, a division of Red Hat</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Email: <A href="mailto:manik@jboss.org">manik@jboss.org</A></DIV><DIV>Telephone: +44 7786 702 706</DIV><DIV>MSN: <A href="mailto:manik@surtani.org">manik@surtani.org</A></DIV><DIV>Yahoo/AIM/Skype: maniksurtani</DIV></SPAN></SPAN><BR class="Apple-interchange-newline"></SPAN> </DIV><BR><DIV><DIV>On 23 Oct 2006, at 07:05, Brian Stansberry wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">FYI on where this sits:</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">1) I checked in all the stuff we were discussing last week.</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">2) When I ran the testsuite, I didn't see regressions.<SPAN class="Apple-converted-space"> </SPAN>We'll see what</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">cc shows.<SPAN class="Apple-converted-space"> </SPAN>The existing testsuite actually excercises the new code</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">fairly well, because even when the old style Element and Properties</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">configs are used, everything gets converted behind the scenes to the new</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">pojos.</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">3) I created a stripped down AS head and created -beans.xml files for</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">the 4 JBC configs that will go in AS 5 -- tomcat, ejb3 sfsb, ejb3</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">entity, and the HAPartition cache.<SPAN class="Apple-converted-space"> </SPAN>They all deploy cleanly, so that's a</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">simple test of the MC-style config.<SPAN class="Apple-converted-space"> </SPAN>Don't know if they do what they</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">should (e.g. does eviction actually happen), but I'm pretty confident</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">about that.<SPAN class="Apple-converted-space"> </SPAN>The -beans.xml files are attached so you can see what they</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">look like.</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">There are details about that can be improved or at least need</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">discussing, but I think it's pretty reasonable for an alpha.</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Cheers,</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Brian Stansberry</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Lead, AS Clustering</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">JBoss, a division of Red Hat</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Ph: 510-396-3864</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">skype: bstansberry<SPAN class="Apple-converted-space"> </SPAN><SPAN><DIV><tc6-cluster-beans.xml></DIV></SPAN><SPAN><DIV><cluster-beans.xml></DIV></SPAN><SPAN><DIV><ejb3-clustered-sfsbcache-beans.xml></DIV></SPAN><SPAN><DIV><ejb3-entity-cache-beans.xml></DIV></SPAN></DIV></BLOCKQUOTE></DIV><BR></DIV></BODY></HTML>