<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 26 Nov 2008, at 22:35, Brian Stansberry wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Manik Surtani wrote:<br><blockquote type="cite">On 26 Nov 2008, at 04:28, Brian Stansberry wrote:<br></blockquote><blockquote type="cite"><blockquote type="cite">I'm not sure exactly what that logic is doing, so I won't try to comment on whether tracking whether nodes were loaded in the TransactionContext makes sense. :)<br></blockquote></blockquote><blockquote type="cite">The purpose of this visitor is to build a List<Modification> from a List<WriteCommand> of commands that have happened in the transaction, which then gets passed to the CacheLoader.prepare() call.<br></blockquote><blockquote type="cite">It does make sense to track load information in the transaction context as well, so let me re-open the JIRA.<br></blockquote><blockquote type="cite"><blockquote type="cite">I'm working to eliminate the biggest hotspot in the attached graphic; once I do I'll test w/ CR1 vs CR2 to get a feel for how much JBCACHE-1446 improved things.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">...done...<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">w/ 3.0.1.CR1: 3677 req/sec<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">w/ 3.0.1.CR2: 3955 req/sec<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">no CL at all: 4930 req/sec (w/ CR2; CL config is commented out)<br></blockquote></blockquote>w/ latest snapshot: 4476 req/sec</div></blockquote><br><div>Nice!</div><br><blockquote type="cite"><div>:-)<br><br>No time today to look at profiler to see if there's any obvious explanation for the diff vs. no CL at all.<br><br><blockquote type="cite">Not bad. So a 7.5% increase in throughput when moving to CR2.<br></blockquote><blockquote type="cite">Cheers<br></blockquote><blockquote type="cite">Manik<br></blockquote><br>-- <br>Brian Stansberry<br>Lead, AS Clustering<br>JBoss, a division of Red Hat<br><a href="mailto:brian.stansberry@redhat.com">brian.stansberry@redhat.com</a><br></div></blockquote></div><br><div apple-content-edited="true"> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>--</div><div>Manik Surtani</div><div>Lead, JBoss Cache</div><div><a href="http://www.jbosscache.org">http://www.jbosscache.org</a><br><a href="mailto:manik@jboss.org" target="_blank">manik@jboss.org</a></div><div><br></div></div></span><br class="Apple-interchange-newline"></div></span><br class="Apple-interchange-newline"> </div><br></body></html>