From benevides at redhat.com Thu Jun 4 09:10:43 2015
From: benevides at redhat.com (Rafael Benevides)
Date: Thu, 04 Jun 2015 09:10:43 -0400
Subject: [jbossdeveloper] Error importing BRMS Quickstarts to JBDS
Message-ID: <55704E53.7080408@redhat.com>
Hi all,
Recently I reported a bug to BRMS Quickstarts where it couldn't be built
when imported to JBDS due to the existence of a maven plugin not covered
by m2e.
When the Quickstart gets imported, it says: "Plugin execution not
covered by lifecycle configuration:
org.commonjava.maven.plugins:project-sources-maven-plugin:0.3:archive
(execution: project-sources-archive, phase: initialize)"
The question is: What's the recommendation from JBDS guys for this?
1 - Avoid non-convered plugins by m2e
2 - Mark it as ignored in the pom.xml when importing it
3 - Mark it as as ignored in eclipse (experimental)
4 - Other recommendation
For reference, the related bug is
https://bugzilla.redhat.com/show_bug.cgi?id=1227861
--
*Rafael Benevides | Senior Software Engineer*
JBoss Developer Materials lead
M: +1-919-592-6255
Red Hat
Better technology. Faster innovation. Powered by community collaboration.
See how it works at www.redhat.com
LinkedIn Youtube
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbossdeveloper/attachments/20150604/918ed4cd/attachment.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: {a8aabf3a-4467-4e37-9bc5-48b1d7b494a2}_LATAM_RedHat.jpg
Type: image/jpeg
Size: 4815 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/jbossdeveloper/attachments/20150604/918ed4cd/attachment.jpg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: linkedin.png
Type: image/png
Size: 597 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/jbossdeveloper/attachments/20150604/918ed4cd/attachment.png
-------------- next part --------------
A non-text attachment was scrubbed...
Name: youtube.png
Type: image/png
Size: 616 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/jbossdeveloper/attachments/20150604/918ed4cd/attachment-0001.png
From sgilda at redhat.com Thu Jun 4 11:09:08 2015
From: sgilda at redhat.com (Sande Gilda)
Date: Thu, 04 Jun 2015 11:09:08 -0400
Subject: [jbossdeveloper] Error importing BRMS Quickstarts to JBDS
In-Reply-To: <55704E53.7080408@redhat.com>
References: <55704E53.7080408@redhat.com>
Message-ID: <55706A14.3030201@redhat.com>
Fred, did we run into this issue with any of the JBoss EAP quickstarts?
It sounds familiar, but I can't find anything.
On 06/04/2015 09:10 AM, Rafael Benevides wrote:
> Hi all,
>
> Recently I reported a bug to BRMS Quickstarts where it couldn't be
> built when imported to JBDS due to the existence of a maven plugin not
> covered by m2e.
>
> When the Quickstart gets imported, it says: "Plugin execution not
> covered by lifecycle configuration:
> org.commonjava.maven.plugins:project-sources-maven-plugin:0.3:archive
> (execution: project-sources-archive, phase: initialize)"
>
> The question is: What's the recommendation from JBDS guys for this?
>
> 1 - Avoid non-convered plugins by m2e
> 2 - Mark it as ignored in the pom.xml when importing it
> 3 - Mark it as as ignored in eclipse (experimental)
> 4 - Other recommendation
>
>
> For reference, the related bug is
> https://bugzilla.redhat.com/show_bug.cgi?id=1227861
>
> --
>
> *Rafael Benevides | Senior Software Engineer*
> JBoss Developer Materials lead
> M: +1-919-592-6255
>
> Red Hat
>
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at www.redhat.com
>
> LinkedIn Youtube
>
>
>
> _______________________________________________
> jbossdeveloper mailing list
> jbossdeveloper at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbossdeveloper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbossdeveloper/attachments/20150604/0e39f99e/attachment-0001.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 4815 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/jbossdeveloper/attachments/20150604/0e39f99e/attachment-0001.jpe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/png
Size: 597 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/jbossdeveloper/attachments/20150604/0e39f99e/attachment-0002.png
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/png
Size: 616 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/jbossdeveloper/attachments/20150604/0e39f99e/attachment-0003.png
From fbricon at redhat.com Thu Jun 4 12:42:02 2015
From: fbricon at redhat.com (Fred Bricon)
Date: Thu, 4 Jun 2015 12:42:02 -0400
Subject: [jbossdeveloper] Error importing BRMS Quickstarts to JBDS
In-Reply-To: <55706A14.3030201@redhat.com>
References: <55704E53.7080408@redhat.com> <55706A14.3030201@redhat.com>
Message-ID:
I have never encountered that plugin before, looks like John wrote it, so if I say something stupid he can correct me.
m2e doesn?t know whether it?s safe to execute or to ignore that plugin in the context of an Eclipse build.
Quickly looking at [1], I would say assembling the project sources is irrelevant to building an app and deploy it *from Eclipse*. So I would say it?s safe to ignore it. But that really depends on the project. I don?t know if it _needs_ it?s sources to be deployed at runtime.
If it?s actually safe to ignore, you have 3 options :
- mark as ignore in pom.xml : you need to do that in each and every quickstart project, but you guarantee your users won?t see an error on import
- mark as ignore in Eclipse : you need to do that once per workspace, but this has to be a user action. You can only document that step in each quickstart
- ask John to add a META-INF/m2e/lifecycle-mapping-metadata.xml file in his plugin [2], so that m2e will safely ignore it by default, with any further pom.xml meddling
As a general rule, I would say that yes, you should try to avoid using non-standard, unsupported maven plugins in Eclipse. You?ll run into less trouble.
If you can?t avoid it, then adding the lifecycle-mapping in the pom (provided it?s safe) will guarantee your users won?t see any errors.
Fred
[1] https://github.com/jdcasey/project-sources-maven-plugin/blob/master/src/main/java/org/commonjava/maven/plugins/projectsrc/ProjectSourcesGoal.java
[2] https://wiki.eclipse.org/M2E_compatible_maven_plugins#Overview
> Le 4 juin 2015 ? 11:09, Sande Gilda a ?crit :
>
> Fred, did we run into this issue with any of the JBoss EAP quickstarts? It sounds familiar, but I can't find anything.
>
> On 06/04/2015 09:10 AM, Rafael Benevides wrote:
>> Hi all,
>>
>> Recently I reported a bug to BRMS Quickstarts where it couldn't be built when imported to JBDS due to the existence of a maven plugin not covered by m2e.
>>
>> When the Quickstart gets imported, it says: "Plugin execution not covered by lifecycle configuration: org.commonjava.maven.plugins:project-sources-maven-plugin:0.3:archive (execution: project-sources-archive, phase: initialize)"
>>
>> The question is: What's the recommendation from JBDS guys for this?
>>
>> 1 - Avoid non-convered plugins by m2e
>> 2 - Mark it as ignored in the pom.xml when importing it
>> 3 - Mark it as as ignored in eclipse (experimental)
>> 4 - Other recommendation
>>
>>
>> For reference, the related bug is https://bugzilla.redhat.com/show_bug.cgi?id=1227861
>>
>> --
>>
>> Rafael Benevides | Senior Software Engineer
>> JBoss Developer Materials lead
>> M: +1-919-592-6255
>>
>>
>>
>> Better technology. Faster innovation. Powered by community collaboration.
>> See how it works at www.redhat.com
>>
>>
>>
>> _______________________________________________
>> jbossdeveloper mailing list
>> jbossdeveloper at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbossdeveloper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbossdeveloper/attachments/20150604/e469e593/attachment.html
From max.andersen at redhat.com Thu Jun 4 18:02:50 2015
From: max.andersen at redhat.com (Max Rydahl Andersen)
Date: Fri, 05 Jun 2015 00:02:50 +0200
Subject: [jbossdeveloper] Error importing BRMS Quickstarts to JBDS
In-Reply-To: <557080A2.5060201@redhat.com>
References: <55704E53.7080408@redhat.com> <55706A14.3030201@redhat.com>
<557080A2.5060201@redhat.com>
Message-ID:
On 4 Jun 2015, at 18:45, John Casey wrote:
> This plugin was written as an alternative to the maven assembly plugin
> IIRC, in order to allow us to standardize the production of
> project-source zips automatically, without affecting any pre-existing
> configurations of the assembly plugin.
>
> I didn't know about the m2e metadata. The plugin should be safe to
> ignore from Eclipse, so I'll add the appropriate metadata and
> re-release the plugin for future use.
thanks.
I commented on the bugzilla before I saw this was another plugin than
what google searches gave me ;)
I still don't grok why this plugin is activated for quickstarts given to
users ?
is this plugin relevant for them to use with their quick start ?
/max
>
> -john
>
> On 06/04/2015 11:42 AM, Fred Bricon wrote:
>> I have never encountered that plugin before, looks like John wrote
>> it,
>> so if I say something stupid he can correct me.
>>
>> m2e doesn?t know whether it?s safe to execute or to ignore that
>> plugin
>> in the context of an Eclipse build.
>> Quickly looking at [1], I would say assembling the project sources is
>> irrelevant to building an app and deploy it *from Eclipse*. So I
>> would
>> say it?s safe to ignore it. But that really depends on the project.
>> I
>> don?t know if it _needs_ it?s sources to be deployed at runtime.
>>
>> If it?s actually safe to ignore, you have 3 options :
>> - mark as ignore in pom.xml : you need to do that in each and every
>> quickstart project, but you guarantee your users won?t see an error
>> on
>> import
>> - mark as ignore in Eclipse : you need to do that once per workspace,
>> but this has to be a user action. You can only document that step in
>> each quickstart
>> - ask John to add a META-INF/m2e/lifecycle-mapping-metadata.xml file
>> in
>> his plugin [2], so that m2e will safely ignore it by default, with
>> any
>> further pom.xml meddling
>>
>> As a general rule, I would say that yes, you should try to avoid
>> using
>> non-standard, unsupported maven plugins in Eclipse. You?ll run into
>> less
>> trouble.
>> If you can?t avoid it, then adding the lifecycle-mapping in the pom
>> (provided it?s safe) will guarantee your users won?t see any
>> errors.
>>
>> Fred
>> [1]
>> https://github.com/jdcasey/project-sources-maven-plugin/blob/master/src/main/java/org/commonjava/maven/plugins/projectsrc/ProjectSourcesGoal.java
>>
>> [2] https://wiki.eclipse.org/M2E_compatible_maven_plugins#Overview
>>
>>> Le 4 juin 2015 ? 11:09, Sande Gilda >> > a ?crit :
>>>
>>> Fred, did we run into this issue with any of the JBoss EAP
>>> quickstarts? It sounds familiar, but I can't find anything.
>>>
>>> On 06/04/2015 09:10 AM, Rafael Benevides wrote:
>>>> Hi all,
>>>>
>>>> Recently I reported a bug to BRMS Quickstarts where it couldn't be
>>>> built when imported to JBDS due to the existence of a maven plugin
>>>> not covered by m2e.
>>>>
>>>> When the Quickstart gets imported, it says: "Plugin execution not
>>>> covered by lifecycle configuration:
>>>> org.commonjava.maven.plugins:project-sources-maven-plugin:0.3:archive
>>>> (execution: project-sources-archive, phase: initialize)"
>>>>
>>>> The question is: What's the recommendation from JBDS guys for this?
>>>>
>>>> 1 - Avoid non-convered plugins by m2e
>>>> 2 - Mark it as ignored in the pom.xml when importing it
>>>> 3 - Mark it as as ignored in eclipse (experimental)
>>>> 4 - Other recommendation
>>>>
>>>>
>>>> For reference, the related bug is
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1227861
>>>>
>>>> --
>>>>
>>>> *Rafael Benevides | Senior Software Engineer*
>>>> JBoss Developer Materials lead
>>>> M: +1-919-592-6255
>>>>
>>>>
>>>>
>>>> Better technology. Faster innovation. Powered by community
>>>> collaboration.
>>>> See how it works at www.redhat.com
>>>>
>>>>
>>>> >>> jointe.png>
>>>>
>>>>
>>>> _______________________________________________
>>>> jbossdeveloper mailing list
>>>> jbossdeveloper at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/jbossdeveloper
>>>
>>
/max
http://about.me/maxandersen
From benevides at redhat.com Fri Jun 5 01:21:28 2015
From: benevides at redhat.com (Rafael Benevides)
Date: Fri, 05 Jun 2015 01:21:28 -0400
Subject: [jbossdeveloper] Error importing BRMS Quickstarts to JBDS
In-Reply-To:
References: <55704E53.7080408@redhat.com> <55706A14.3030201@redhat.com>
<557080A2.5060201@redhat.com>
Message-ID: <557131D8.1000900@redhat.com>
I'll let Ryan and Petr to answer those questions since it was not part
of initial quickstarts.
On 6/4/15 18:02, Max Rydahl Andersen wrote:
> On 4 Jun 2015, at 18:45, John Casey wrote:
>
>> This plugin was written as an alternative to the maven assembly
>> plugin IIRC, in order to allow us to standardize the production of
>> project-source zips automatically, without affecting any pre-existing
>> configurations of the assembly plugin.
>>
>> I didn't know about the m2e metadata. The plugin should be safe to
>> ignore from Eclipse, so I'll add the appropriate metadata and
>> re-release the plugin for future use.
>
> thanks.
>
> I commented on the bugzilla before I saw this was another plugin than
> what google searches gave me ;)
>
> I still don't grok why this plugin is activated for quickstarts given
> to users ?
>
> is this plugin relevant for them to use with their quick start ?
>
> /max
>
>
>>
>> -john
>>
>> On 06/04/2015 11:42 AM, Fred Bricon wrote:
>>> I have never encountered that plugin before, looks like John wrote it,
>>> so if I say something stupid he can correct me.
>>>
>>> m2e doesn?t know whether it?s safe to execute or to ignore that plugin
>>> in the context of an Eclipse build.
>>> Quickly looking at [1], I would say assembling the project sources is
>>> irrelevant to building an app and deploy it *from Eclipse*. So I would
>>> say it?s safe to ignore it. But that really depends on the project. I
>>> don?t know if it _needs_ it?s sources to be deployed at runtime.
>>>
>>> If it?s actually safe to ignore, you have 3 options :
>>> - mark as ignore in pom.xml : you need to do that in each and every
>>> quickstart project, but you guarantee your users won?t see an error on
>>> import
>>> - mark as ignore in Eclipse : you need to do that once per workspace,
>>> but this has to be a user action. You can only document that step in
>>> each quickstart
>>> - ask John to add a META-INF/m2e/lifecycle-mapping-metadata.xml
>>> file in
>>> his plugin [2], so that m2e will safely ignore it by default, with any
>>> further pom.xml meddling
>>>
>>> As a general rule, I would say that yes, you should try to avoid using
>>> non-standard, unsupported maven plugins in Eclipse. You?ll run into
>>> less
>>> trouble.
>>> If you can?t avoid it, then adding the lifecycle-mapping in the pom
>>> (provided it?s safe) will guarantee your users won?t see any errors.
>>>
>>> Fred
>>> [1]
>>> https://github.com/jdcasey/project-sources-maven-plugin/blob/master/src/main/java/org/commonjava/maven/plugins/projectsrc/ProjectSourcesGoal.java
>>>
>>>
>>> [2] https://wiki.eclipse.org/M2E_compatible_maven_plugins#Overview
>>>
>>>> Le 4 juin 2015 ? 11:09, Sande Gilda >>> > a ?crit :
>>>>
>>>> Fred, did we run into this issue with any of the JBoss EAP
>>>> quickstarts? It sounds familiar, but I can't find anything.
>>>>
>>>> On 06/04/2015 09:10 AM, Rafael Benevides wrote:
>>>>> Hi all,
>>>>>
>>>>> Recently I reported a bug to BRMS Quickstarts where it couldn't be
>>>>> built when imported to JBDS due to the existence of a maven plugin
>>>>> not covered by m2e.
>>>>>
>>>>> When the Quickstart gets imported, it says: "Plugin execution not
>>>>> covered by lifecycle configuration:
>>>>> org.commonjava.maven.plugins:project-sources-maven-plugin:0.3:archive
>>>>> (execution: project-sources-archive, phase: initialize)"
>>>>>
>>>>> The question is: What's the recommendation from JBDS guys for this?
>>>>>
>>>>> 1 - Avoid non-convered plugins by m2e
>>>>> 2 - Mark it as ignored in the pom.xml when importing it
>>>>> 3 - Mark it as as ignored in eclipse (experimental)
>>>>> 4 - Other recommendation
>>>>>
>>>>>
>>>>> For reference, the related bug is
>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1227861
>>>>>
>>>>> --
>>>>>
>>>>> *Rafael Benevides | Senior Software Engineer*
>>>>> JBoss Developer Materials lead
>>>>> M: +1-919-592-6255
>>>>>
>>>>>
>>>>>
>>>>> Better technology. Faster innovation. Powered by community
>>>>> collaboration.
>>>>> See how it works at www.redhat.com
>>>>>
>>>>> >>>> jointe.png>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jbossdeveloper mailing list
>>>>> jbossdeveloper at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/jbossdeveloper
>>>>
>>>
>
>
> /max
> http://about.me/maxandersen
From rzhang at redhat.com Fri Jun 5 06:54:01 2015
From: rzhang at redhat.com (Ryan Zhang)
Date: Fri, 05 Jun 2015 18:54:01 +0800
Subject: [jbossdeveloper] Error importing BRMS Quickstarts to JBDS
In-Reply-To: <557131D8.1000900@redhat.com>
References: <55704E53.7080408@redhat.com> <55706A14.3030201@redhat.com>
<557080A2.5060201@redhat.com>
<557131D8.1000900@redhat.com>
Message-ID: <55717FC9.3060105@redhat.com>
Hi,
Yes, the plugin is added for productization purpose during the prod build.
After discussion with my team, we think we can drop the
project-sources-maven-plugin for future version.
The reason it was added is that we use it to produce a source package
which contains the real product version changes applied by
Pom-Manipulator-Ext[1]. It work with PME and has been applied to all
project source we shipped to customer.
I agree that the plugin is irrelevant to customer usage on quickstarts
and we can provide the correct source based on assembly instead of
relying on the project-source-plugin. So we decided we can drop it from
quickstarts.
I will assign the related bugzilla on me and make sure the change
happens for future version.
Thanks for the investigation.
[1]:https://github.com/jdcasey/pom-version-manipulator
Thanks,
Ryan
On 06/05/2015 01:21 PM, Rafael Benevides wrote:
> I'll let Ryan and Petr to answer those questions since it was not part
> of initial quickstarts.
>
>
> On 6/4/15 18:02, Max Rydahl Andersen wrote:
>> On 4 Jun 2015, at 18:45, John Casey wrote:
>>
>>> This plugin was written as an alternative to the maven assembly
>>> plugin IIRC, in order to allow us to standardize the production of
>>> project-source zips automatically, without affecting any pre-existing
>>> configurations of the assembly plugin.
>>>
>>> I didn't know about the m2e metadata. The plugin should be safe to
>>> ignore from Eclipse, so I'll add the appropriate metadata and
>>> re-release the plugin for future use.
>>
>> thanks.
>>
>> I commented on the bugzilla before I saw this was another plugin than
>> what google searches gave me ;)
>>
>> I still don't grok why this plugin is activated for quickstarts given
>> to users ?
>>
>> is this plugin relevant for them to use with their quick start ?
>>
>> /max
>>
>>
>>>
>>> -john
>>>
>>> On 06/04/2015 11:42 AM, Fred Bricon wrote:
>>>> I have never encountered that plugin before, looks like John wrote it,
>>>> so if I say something stupid he can correct me.
>>>>
>>>> m2e doesn?t know whether it?s safe to execute or to ignore that plugin
>>>> in the context of an Eclipse build.
>>>> Quickly looking at [1], I would say assembling the project sources is
>>>> irrelevant to building an app and deploy it *from Eclipse*. So I would
>>>> say it?s safe to ignore it. But that really depends on the project. I
>>>> don?t know if it _needs_ it?s sources to be deployed at runtime.
>>>>
>>>> If it?s actually safe to ignore, you have 3 options :
>>>> - mark as ignore in pom.xml : you need to do that in each and every
>>>> quickstart project, but you guarantee your users won?t see an error on
>>>> import
>>>> - mark as ignore in Eclipse : you need to do that once per workspace,
>>>> but this has to be a user action. You can only document that step in
>>>> each quickstart
>>>> - ask John to add a META-INF/m2e/lifecycle-mapping-metadata.xml
>>>> file in
>>>> his plugin [2], so that m2e will safely ignore it by default, with any
>>>> further pom.xml meddling
>>>>
>>>> As a general rule, I would say that yes, you should try to avoid using
>>>> non-standard, unsupported maven plugins in Eclipse. You?ll run into
>>>> less
>>>> trouble.
>>>> If you can?t avoid it, then adding the lifecycle-mapping in the pom
>>>> (provided it?s safe) will guarantee your users won?t see any errors.
>>>>
>>>> Fred
>>>> [1]
>>>> https://github.com/jdcasey/project-sources-maven-plugin/blob/master/src/main/java/org/commonjava/maven/plugins/projectsrc/ProjectSourcesGoal.java
>>>>
>>>>
>>>> [2] https://wiki.eclipse.org/M2E_compatible_maven_plugins#Overview
>>>>
>>>>> Le 4 juin 2015 ? 11:09, Sande Gilda >>>> > a ?crit :
>>>>>
>>>>> Fred, did we run into this issue with any of the JBoss EAP
>>>>> quickstarts? It sounds familiar, but I can't find anything.
>>>>>
>>>>> On 06/04/2015 09:10 AM, Rafael Benevides wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> Recently I reported a bug to BRMS Quickstarts where it couldn't be
>>>>>> built when imported to JBDS due to the existence of a maven plugin
>>>>>> not covered by m2e.
>>>>>>
>>>>>> When the Quickstart gets imported, it says: "Plugin execution not
>>>>>> covered by lifecycle configuration:
>>>>>> org.commonjava.maven.plugins:project-sources-maven-plugin:0.3:archive
>>>>>> (execution: project-sources-archive, phase: initialize)"
>>>>>>
>>>>>> The question is: What's the recommendation from JBDS guys for this?
>>>>>>
>>>>>> 1 - Avoid non-convered plugins by m2e
>>>>>> 2 - Mark it as ignored in the pom.xml when importing it
>>>>>> 3 - Mark it as as ignored in eclipse (experimental)
>>>>>> 4 - Other recommendation
>>>>>>
>>>>>>
>>>>>> For reference, the related bug is
>>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1227861
>>>>>>
>>>>>> --
>>>>>>
>>>>>> *Rafael Benevides | Senior Software Engineer*
>>>>>> JBoss Developer Materials lead
>>>>>> M: +1-919-592-6255
>>>>>>
>>>>>>
>>>>>>
>>>>>> Better technology. Faster innovation. Powered by community
>>>>>> collaboration.
>>>>>> See how it works at www.redhat.com
>>>>>>
>>>>>> >>>>> jointe.png>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> jbossdeveloper mailing list
>>>>>> jbossdeveloper at lists.jboss.org
>>>>>> https://lists.jboss.org/mailman/listinfo/jbossdeveloper
>>>>>
>>>>
>>
>>
>> /max
>> http://about.me/maxandersen
>
From jcasey at redhat.com Thu Jun 4 12:45:22 2015
From: jcasey at redhat.com (John Casey)
Date: Thu, 04 Jun 2015 11:45:22 -0500
Subject: [jbossdeveloper] Error importing BRMS Quickstarts to JBDS
In-Reply-To:
References: <55704E53.7080408@redhat.com> <55706A14.3030201@redhat.com>
Message-ID: <557080A2.5060201@redhat.com>
This plugin was written as an alternative to the maven assembly plugin
IIRC, in order to allow us to standardize the production of
project-source zips automatically, without affecting any pre-existing
configurations of the assembly plugin.
I didn't know about the m2e metadata. The plugin should be safe to
ignore from Eclipse, so I'll add the appropriate metadata and re-release
the plugin for future use.
-john
On 06/04/2015 11:42 AM, Fred Bricon wrote:
> I have never encountered that plugin before, looks like John wrote it,
> so if I say something stupid he can correct me.
>
> m2e doesn?t know whether it?s safe to execute or to ignore that plugin
> in the context of an Eclipse build.
> Quickly looking at [1], I would say assembling the project sources is
> irrelevant to building an app and deploy it *from Eclipse*. So I would
> say it?s safe to ignore it. But that really depends on the project. I
> don?t know if it _needs_ it?s sources to be deployed at runtime.
>
> If it?s actually safe to ignore, you have 3 options :
> - mark as ignore in pom.xml : you need to do that in each and every
> quickstart project, but you guarantee your users won?t see an error on
> import
> - mark as ignore in Eclipse : you need to do that once per workspace,
> but this has to be a user action. You can only document that step in
> each quickstart
> - ask John to add a META-INF/m2e/lifecycle-mapping-metadata.xml file in
> his plugin [2], so that m2e will safely ignore it by default, with any
> further pom.xml meddling
>
> As a general rule, I would say that yes, you should try to avoid using
> non-standard, unsupported maven plugins in Eclipse. You?ll run into less
> trouble.
> If you can?t avoid it, then adding the lifecycle-mapping in the pom
> (provided it?s safe) will guarantee your users won?t see any errors.
>
> Fred
> [1]
> https://github.com/jdcasey/project-sources-maven-plugin/blob/master/src/main/java/org/commonjava/maven/plugins/projectsrc/ProjectSourcesGoal.java
>
> [2] https://wiki.eclipse.org/M2E_compatible_maven_plugins#Overview
>
>> Le 4 juin 2015 ? 11:09, Sande Gilda > > a ?crit :
>>
>> Fred, did we run into this issue with any of the JBoss EAP
>> quickstarts? It sounds familiar, but I can't find anything.
>>
>> On 06/04/2015 09:10 AM, Rafael Benevides wrote:
>>> Hi all,
>>>
>>> Recently I reported a bug to BRMS Quickstarts where it couldn't be
>>> built when imported to JBDS due to the existence of a maven plugin
>>> not covered by m2e.
>>>
>>> When the Quickstart gets imported, it says: "Plugin execution not
>>> covered by lifecycle configuration:
>>> org.commonjava.maven.plugins:project-sources-maven-plugin:0.3:archive
>>> (execution: project-sources-archive, phase: initialize)"
>>>
>>> The question is: What's the recommendation from JBDS guys for this?
>>>
>>> 1 - Avoid non-convered plugins by m2e
>>> 2 - Mark it as ignored in the pom.xml when importing it
>>> 3 - Mark it as as ignored in eclipse (experimental)
>>> 4 - Other recommendation
>>>
>>>
>>> For reference, the related bug is
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1227861
>>>
>>> --
>>>
>>> *Rafael Benevides | Senior Software Engineer*
>>> JBoss Developer Materials lead
>>> M: +1-919-592-6255
>>>
>>>
>>>
>>> Better technology. Faster innovation. Powered by community
>>> collaboration.
>>> See how it works at www.redhat.com
>>>
>>> >> jointe.png>
>>>
>>>
>>> _______________________________________________
>>> jbossdeveloper mailing list
>>> jbossdeveloper at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jbossdeveloper
>>
>