[jbosstools-dev] Re: Fwd: [jbosstools-commits] JBoss Tools SVN: r5304 - trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam.

[Max Rydahl Andersen]

> why are we adding new features and "largish" new antlr dependencies in  
> 2.0.1 !?

Is vyemialyanchyk on the dev-list ?

I found that we now blindly included lgpl code from JBoss Seam into our  
plugins without any
notice on the files. We need to fix that! (LGPL should be marked clearly  
as such and where it comes from and put in .xpl package)

Furthermore it seems like there are test code mixed in with the main code  
- need to fix that too (this should
be in the test plugins)

And I still fail to understand what ant-antlr.jar and antlr.jar is doing  
on the runtime classpath of our plugins.
antlr-runtime.jar I understand since the parser is dependent on it, but  
again why is this being added to 2.0.1 and
is this ok at runtime considering that antlr is to be found in other  
plugins too (hibernate for one) !?

/max

> -max
>
> ------- Forwarded message -------
> From: jbosstools-commits at lists.jboss.org
> To: jbosstools-commits at lists.jboss.org
> Cc:
> Subject: [jbosstools-commits] JBoss Tools SVN: r5304 -  
> trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam.
> Date: Fri, 14 Dec 2007 13:40:11 +0100
>
> Author: vyemialyanchyk
> Date: 2007-12-14 07:40:10 -0500 (Fri, 14 Dec 2007)
> New Revision: 5304
>
> Modified:
>     trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/.classpath
>     trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/build.properties
> Log:
> http://jira.jboss.com/jira/browse/JBIDE-1449
>
> Modified: trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/.classpath
> ===================================================================
> --- trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/.classpath	2007-12-14  
> 12:39:40 UTC (rev 5303)
> +++ trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/.classpath	2007-12-14  
> 12:40:10 UTC (rev 5304)
> @@ -3,5 +3,8 @@
>   	<classpathentry kind="src" path="src"/>
>   	<classpathentry kind="con"  
> path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
>   	<classpathentry kind="con"  
> path="org.eclipse.pde.core.requiredPlugins"/>
> +	<classpathentry kind="lib" path="lib/ant-antlr.jar"/>
> +	<classpathentry kind="lib" path="lib/antlr.jar"/>
> +	<classpathentry kind="lib" path="lib/antlr-runtime.jar"/>
>   	<classpathentry kind="output" path="bin"/>
>   </classpath>
>
> Modified: trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/build.properties
> ===================================================================
> ---  
> trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/build.properties	2007-12-14  
> 12:39:40 UTC (rev 5303)
> +++  
> trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/build.properties	2007-12-14  
> 12:40:10 UTC (rev 5304)
> @@ -3,11 +3,10 @@
>   bin.includes = META-INF/,\
>                  .,\
>                  plugin.xml,\
> +               lib/,\
> +               lib/ant-antlr.jar,\
> +               lib/antlr.jar,\
> +               lib/antlr-runtime.jar,\
>                  templates/
>   src.includes = templates/,\
> -               src/,\
> -               plugin.xml,\
> -               build.properties,\
> -               META-INF/,\
> -               .project,\
> -               .classpath
> +               src/
>
> _______________________________________________
> jbosstools-commits mailing list
> jbosstools-commits at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosstools-commits
>
>
>



-- 
--
Max Rydahl Andersen
callto://max.rydahl.andersen

Hibernate
max at hibernate.org
http://hibernate.org

JBoss a division of Red Hat
max.andersen at jboss.com